Mailing List Archive

Update of /cvsroot/python/python/dist/src/Objects
In directory usw-pr-cvs1:/tmp/cvs-serv5683/Objects

Modified Files:
methodobject.c typeobject.c
Log Message:
Introduce two new flag bits that can be set in a PyMethodDef method
descriptor, as used for the tp_methods slot of a type. These new flag
bits are both optional, and mutually exclusive. Most methods will not
use either. These flags are used to create special method types which
exist in the same namespace as normal methods without having to use
tedious construction code to insert the new special method objects in
the type's tp_dict after PyType_Ready() has been called.

If METH_CLASS is specified, the method will represent a class method
like that returned by the classmethod() built-in.

If METH_STATIC is specified, the method will represent a static method
like that returned by the staticmethod() built-in.

These flags may not be used in the PyMethodDef table for modules since
these special method types are not meaningful in that case; a
ValueError will be raised if these flags are found in that context.


Index: methodobject.c
===================================================================
RCS file: /cvsroot/python/python/dist/src/Objects/methodobject.c,v
retrieving revision 2.41
retrieving revision 2.42
diff -C2 -d -r2.41 -r2.42
*** methodobject.c 18 Mar 2002 20:44:53 -0000 2.41
--- methodobject.c 28 Mar 2002 05:33:33 -0000 2.42
***************
*** 63,67 ****
PyCFunction meth = PyCFunction_GET_FUNCTION(func);
PyObject *self = PyCFunction_GET_SELF(func);
! int flags = PyCFunction_GET_FLAGS(func);
int size = PyTuple_GET_SIZE(arg);

--- 63,67 ----
PyCFunction meth = PyCFunction_GET_FUNCTION(func);
PyObject *self = PyCFunction_GET_SELF(func);
! int flags = PyCFunction_GET_FLAGS(func) & ~(METH_CLASS | METH_STATIC);
int size = PyTuple_GET_SIZE(arg);


Index: typeobject.c
===================================================================
RCS file: /cvsroot/python/python/dist/src/Objects/typeobject.c,v
retrieving revision 2.130
retrieving revision 2.131
diff -C2 -d -r2.130 -r2.131
*** typeobject.c 17 Mar 2002 18:56:20 -0000 2.130
--- typeobject.c 28 Mar 2002 05:33:33 -0000 2.131
***************
*** 1695,1698 ****
--- 1695,1712 ----
/* Initialize the __dict__ in a type object */

+ static PyObject *
+ create_specialmethod(PyMethodDef *meth, PyObject *(*func)(PyObject *))
+ {
+ PyObject *cfunc;
+ PyObject *result;
+
+ cfunc = PyCFunction_New(meth, NULL);
+ if (cfunc == NULL)
+ return NULL;
+ result = func(cfunc);
+ Py_DECREF(cfunc);
+ return result;
+ }
+
static int
add_methods(PyTypeObject *type, PyMethodDef *meth)
***************
*** 1704,1711 ****
if (PyDict_GetItemString(dict, meth->ml_name))
continue;
! descr = PyDescr_NewMethod(type, meth);
if (descr == NULL)
return -1;
! if (PyDict_SetItemString(dict,meth->ml_name, descr) < 0)
return -1;
Py_DECREF(descr);
--- 1718,1738 ----
if (PyDict_GetItemString(dict, meth->ml_name))
continue;
! if (meth->ml_flags & METH_CLASS) {
! if (meth->ml_flags & METH_STATIC) {
! PyErr_SetString(PyExc_ValueError,
! "method cannot be both class and static");
! return -1;
! }
! descr = create_specialmethod(meth, PyClassMethod_New);
! }
! else if (meth->ml_flags & METH_STATIC) {
! descr = create_specialmethod(meth, PyStaticMethod_New);
! }
! else {
! descr = PyDescr_NewMethod(type, meth);
! }
if (descr == NULL)
return -1;
! if (PyDict_SetItemString(dict, meth->ml_name, descr) < 0)
return -1;
Py_DECREF(descr);