Mailing List Archive

https://github.com/python/cpython/commit/42ae924d278c48a719fb0ab86357f3235a9f7ab9
commit: 42ae924d278c48a719fb0ab86357f3235a9f7ab9
branch: main
author: Petr Viktorin <encukou@gmail.com>
committer: encukou <encukou@gmail.com>
date: 2024-03-22T10:42:18+01:00
summary:

gh-117127: glob tests: Reopen dir_fd to pick up directory changes (GH-117128)

files:
M Lib/test/test_glob.py

diff --git a/Lib/test/test_glob.py b/Lib/test/test_glob.py
index 2de997501039ad..6719bdbb0cc9b1 100644
--- a/Lib/test/test_glob.py
+++ b/Lib/test/test_glob.py
@@ -41,6 +41,11 @@ def setUp(self):
os.symlink(self.norm('broken'), self.norm('sym1'))
os.symlink('broken', self.norm('sym2'))
os.symlink(os.path.join('a', 'bcd'), self.norm('sym3'))
+ self.open_dirfd()
+
+ def open_dirfd(self):
+ if self.dir_fd is not None:
+ os.close(self.dir_fd)
if {os.open, os.stat} <= os.supports_dir_fd and os.scandir in os.supports_fd:
self.dir_fd = os.open(self.tempdir, os.O_RDONLY | os.O_DIRECTORY)
else:
@@ -350,6 +355,10 @@ def test_glob_non_directory(self):
def test_glob_named_pipe(self):
path = os.path.join(self.tempdir, 'mypipe')
os.mkfifo(path)
+
+ # gh-117127: Reopen self.dir_fd to pick up directory changes
+ self.open_dirfd()
+
self.assertEqual(self.rglob('mypipe'), [path])
self.assertEqual(self.rglob('mypipe*'), [path])
self.assertEqual(self.rglob('mypipe', ''), [])

_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-leave@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: list-python-checkins@lists.gossamer-threads.com