Mailing List Archive: [issue1740] use unittest for test

[issue1740] use unittest for test_logging

Jan 5, 2008, 5:40 PM

Post #1 of 3 (185 views)

New submission from Antoine Pitrou:

Lib/test.test_logging.py doesn't use unittest. Here is a patch (against
SVN trunk) to fix the problem.

----------
components: Tests
files: logtest.patch
messages: 59348
nosy: pitrou
severity: normal
status: open
title: use unittest for test_logging
versions: Python 2.6
Added file: http://bugs.python.org/file9073/logtest.patch

__________________________________
Tracker <report@bugs.python.org>
<http://bugs.python.org/issue1740>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue1740] use unittest for test_logging [ In reply to ]

report at bugs

Jan 5, 2008, 8:33 PM

Post #2 of 3 (173 views)

Permalink

Christian Heimes added the comment:

Thanks! :)

I quick review hasn't shown any larger issues but it need a proper
review before it can be submitted.

You probably should save _levelNames, _loggerClass, root, Logger.root
and Logger.manager in setUp and reset the objects in tearDown.

----------
keywords: +patch
nosy: +tiran
priority: -> normal
resolution: -> accepted
type: -> resource usage

__________________________________
Tracker <report@bugs.python.org>
<http://bugs.python.org/issue1740>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue1740] use unittest for test_logging [ In reply to ]

report at bugs

Jan 5, 2008, 8:48 PM

Post #3 of 3 (181 views)

Permalink

Antoine Pitrou added the comment:

Ok here is an updated patch with slightly more complete setUp/tearDown
semantics. I don't backup all the objects though since some of them
(e.g. _loggerClass) aren't touched by the tests.

Added file: http://bugs.python.org/file9074/logtest.patch

__________________________________
Tracker <report@bugs.python.org>
<http://bugs.python.org/issue1740>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com