On 4/7/21 10:10 PM, James E Keenan wrote:
> Ben Bullock wrote:
>
> #####
> I've assembled a pre-release here:
>
> https://github.com/benkasminbullock/extutils-parsexs/releases/tag/3.43_01
> #####
>
> What is the point (commit) in Perl 5 blead to which we should be
> comparing the code in the tarball at the above URL?
>
> (It appears to be later than perl-5.32.1 but earlier than HEAD.)
>
Ben, I'm concerned that in your tarball you are not completely capturing
the state of ExtUtils-ParseXS as it currently appears in blead. As a
consequence, if you were to release what's in your tarball to CPAN, what
is stated to be version 3.43 on CPAN would be subtly different from what
will presumably be version 3.43 in dist/ExtUtils-ParseXS when we release
perl-5.34.0 next month.
If we look at Perl 5 blead we see that the last changes to
dist/ExtUtils-ParseXS were a series of 4 commits on March 24 of this
year, 2 of which were substantive fixes submitted by Ed J and 2 of which
were p5p housekeeping by me:
#####
$ git log --format=fuller --reverse
7365f8f7fa7940e5e4422c10fc07c18aa0447ee3..HEAD -- dist/ExtUtils-ParseXS/
|cat
commit e3a57d70d0b8c89c2c37833064dd4e2ecc302b58
Author: Ed J <mohawk2@users.noreply.github.com>
AuthorDate: Sat Mar 20 16:35:25 2021 +0000
Commit: James E Keenan <jkeenan@cpan.org>
CommitDate: Wed Mar 24 08:41:56 2021 -0400
use PERL_VERSION_LE not 5.33+ PERL_VERSION_LT
As ExtUtils::ParseXS is dual-life it needs to use stable Perl macros.
commit f1f3e1235de245a2fc5947224992ed28b9e75f99
Author: Ed J <mohawk2@users.noreply.github.com>
AuthorDate: Sun Apr 21 22:18:13 2019 +0100
Commit: James E Keenan <jkeenan@cpan.org>
CommitDate: Wed Mar 24 08:41:56 2021 -0400
ExtUtils::ParseXS fix error-message bug
commit 7ed63354fd06d48bccb0abf1278e6333edf41536
Author: James E Keenan <jkeenan@cpan.org>
AuthorDate: Wed Mar 24 14:20:46 2021 +0000
Commit: James E Keenan <jkeenan@cpan.org>
CommitDate: Wed Mar 24 14:20:46 2021 +0000
Bump $VERSION to keep porting tests happy
commit 99155265b6644bc3178a61cd413e989b2ecf90d9
Author: James E Keenan <jkeenan@cpan.org>
AuthorDate: Wed Mar 24 10:44:08 2021 -0400
Commit: James E Keenan <jkeenan@cpan.org>
CommitDate: Wed Mar 24 10:44:08 2021 -0400
Bump $VERSION throughout dist/ExtUtils-ParseXS/lib
Build was gagging after mktables.lst.
#####
So, if I had been asked to prepare a CPAN release of ExtUtils-ParseXS,
commit 99155265 would have been my starting point.
Now, if (a) I download and unpack your tarball, then (b) do a "git
checkout 99155265", and then (c) diff blead against your tarball, I come
up with the diff attached (eupp.99155265b6.vs.proposed.diff). Much of
the diff is housekeeping, but I'm concerned that Ed J's changes don't
make the diff. Also missing are changes to
dist/ExtUtils-ParseXS/t/XSTest.xs and dist/ExtUtils-ParseXS/t/XSUsage.xs
that were committed in Nov 2017 in commit a8c15670317. The most
relevant differences I am attaching as "relevant.diff".
Up until now most CPAN releases of blead-upstream, dual-life modules
(i.e., those under dist/) have been performed by whoever was the current
pumpking. It has not been a widely distributed task and, perhaps as a
consequence, we lack (to the best of my knowledge) specific instructions
for doing such releases. So it's not surprising that there may be
confusion or differences of opinion as to "where do we start from."
I want to further acknowledge that dual-life-ing of ExtUtils-ParseXS is
particularly challenging, as its Makefile in core is automatically
generated while its Makefile.PL on CPAN is rather complicated.
Sawyer, Rik, can we get clarification on this?
Thank you very much.
Jim Keenan