Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

--- Comment #2 from Ryan <ryman559@hotmail.com> ---
Seems the behaviour is different between the two.

sftp:

If the -R flag is specified then directories will be copied
recursively. Note that sftp does not follow symbolic links when
performing recursive transfers.

scp:

-r Recursively copy entire directories. Note that scp
follows symbolic links encountered in the tree traversal.

--
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |djm@mindrot.org,
| |dtucker@dtucker.net
Attachment #3728| |ok?(dtucker@dtucker.net)
Flags| |

--- Comment #3 from Damien Miller <djm@mindrot.org> ---
Created attachment 3728
--> https://bugzilla.mindrot.org/attachment.cgi?id=3728&action=edit
handle symlinked directories on sftp upload path

The sftp upload code wasn't handling symlinked directories correctly,
only simlinked files. This should fix it.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3728|ok?(dtucker@dtucker.net) |ok+
Flags| |

--- Comment #4 from Darren Tucker <dtucker@dtucker.net> ---
Comment on attachment 3728
--> https://bugzilla.mindrot.org/attachment.cgi?id=3728
handle symlinked directories on sftp upload path

should there be a regression test for this?

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3728|0 |1
is obsolete| |
Attachment #3729| |ok?
Flags| |

--- Comment #5 from Damien Miller <djm@mindrot.org> ---
Created attachment 3729
--> https://bugzilla.mindrot.org/attachment.cgi?id=3729&action=edit
fix download path too, add regress test

regress test too. The download path was also similarly broken

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

--- Comment #6 from Damien Miller <djm@mindrot.org> ---
sigh, pretend this bit

> -for mode in scp sftp ; do
> +for mode in sftp ; do

is already reverted when reading the regress diff

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3729|ok? |ok+
Flags| |

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3611

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Blocks| |3605
Status|NEW |RESOLVED

--- Comment #7 from Damien Miller <djm@mindrot.org> ---
This has been committed and will be in OpenSSH 9.5, due in a few months
- thanks!


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3605
[Bug 3605] Tracking bug for OpenSSH 9.5
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs