Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=3059

Bug ID: 3059
Summary: Typos and copy-paste errors in the code
(openbsd-compat/bsd-misc.c)
Product: Portable OpenSSH
Version: 8.0p1
Hardware: Other
OS: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Miscellaneous
Assignee: unassigned-bugs@mindrot.org
Reporter: samuel@cendio.se

Created attachment 3311
--> https://bugzilla.mindrot.org/attachment.cgi?id=3311&action=edit
Fix errors in openbsd-compat/bsd-misc.c

In the new code for 8.0 in openbsd-compat/bsd-misc.c in the functions
"fchownat" and "fchmodat" there are a number of errors:

In fchownat at line 178:

# ifndef HAVE_FCHOWN
return chown(pathname, owner, group);
# else

There is no parameter called "pathname", it should simply be "path"

Same goes for the function "fchmodat" at line 209:

# ifndef HAVE_FCHOWN
return chown(pathname, owner, group);
# else

The parameter should be "path", and judging by the function name and
the ifndef, the call should probably be chmod instead:

# ifndef HAVE_FCHMOD
return chmod(path, mode);
# else

Attached my patch.

--
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs