Mailing List Archive

[Bug 1469] Should sshd detect and reject vulnerable SSH keys (re: Debian DSA-1571 and DSA-1576)
https://bugzilla.mindrot.org/show_bug.cgi?id=1469


Alex Howells <alex.howells@0wn3d.us> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |alex.howells@0wn3d.us




--- Comment #1 from Alex Howells <alex.howells@0wn3d.us> 2008-05-25 06:35:22 ---
I think there is a considerable disadvantage to the implementation of
this feature: users are liable assume any vulnerable key will be
detected and rejected, which is likely a false assumption :(

What certain distributions are including is not a complete list, their
utilities/patches seem to analyze the first 80-84 bits of a fingerprint
-- this is liable to give false positives, and the inclusive blacklists
only cover the most basic permutations of key, a la;

1024-bit DSA
768-bit RSA
1024-bit RSA
2048-bit RSA

As far as I am aware they don't cover 4096-bit RSA, and any user who
had generated with `ssh-keygen -b 8150 -t rsa` would not be blocked.

I think this might be a feature which needs to be maintained
externally. That way there can be good documentation showing what
permutations would be detected and users are less liable to make nasty
assumptions... Perhaps another good reason to not include this is the
'bloat factor'? It'd probably make releases considerably larger?

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1469] Should sshd detect and reject vulnerable SSH keys (re: Debian DSA-1571 and DSA-1576) [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=1469





--- Comment #2 from Alex Howells <alex.howells@0wn3d.us> 2008-05-25 06:38:59 ---
> As far as I am aware they don't cover 4096-bit RSA, and any user who
> had generated with `ssh-keygen -b 8150 -t rsa` would not be blocked.

Sorry, perhaps I should clarify -- any user who has generated with a
non-standard key length would not be covered and it would be
computationally impossible to generate all 32767 permutations per
architecture / word length vs. all possible key length possibilities.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1469] Should sshd detect and reject vulnerable SSH keys (re: Debian DSA-1571 and DSA-1576) [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=1469





--- Comment #3 from Colin Watson <cjwatson@debian.org> 2008-05-26 23:44:30 ---
Created an attachment (id=1508)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1508)
blacklisting and ssh-vulnkey

Here's the current patch we're using for this in Debian. I've tried to
ensure that it can at least theoretically be acceptable on all systems,
but am more than happy to work on this as necessary; I think it's
important to deploy this as widely as possible.

I believe that the blacklisting feature itself is separate from the
distribution of the blacklist files. Those are, as observed, large,
unwieldy from the point of view of distribution with OpenSSH, and not
necessarily complete (although the published blacklists for each key
type and size are complete with respect to this particular
vulnerability). However, I can imagine other uses for the blacklisting
code itself. For instance, a sysadmin responding to a compromised
machine might want to use it as a quick way to lock out use of
particular keys.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1469] Should sshd detect and reject vulnerable SSH keys (re: Debian DSA-1571 and DSA-1576) [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=1469


Colin Watson <cjwatson@debian.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |cjwatson@debian.org




--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1469] Should sshd detect and reject vulnerable SSH keys (re: Debian DSA-1571 and DSA-1576) [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=1469


Colin Watson <cjwatson@debian.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1508|0 |1
is obsolete| |




--- Comment #4 from Colin Watson <cjwatson@debian.org> 2008-05-31 08:10:09 ---
Created an attachment (id=1510)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1510)
blacklist patch from Debian 1:4.7p1-12

Here's an updated version to align with the most recent Debian upload.
Changes from the previous attachment:

* Refactor rejection of blacklisted user keys into a single
reject_blacklisted_key function in auth.c (thanks, Dmitry V.
Levin).
* Fix memory leak of blacklisted host keys (thanks, Dmitry V. Levin).

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs