Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=1349


David Woodhouse <dwmw2@infradead.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1335|0 |1
is obsolete| |




--- Comment #2 from David Woodhouse <dwmw2@infradead.org> 2008-03-06 23:43:32 ---
Created an attachment (id=1461)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1461)
updated patch

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1349





--- Comment #3 from David Woodhouse <dwmw2@infradead.org> 2008-03-06 23:45:25 ---
I verified that in combination with my patch for bug #1329, this still
copes correctly with stale sockets.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1349





--- Comment #4 from Tony Finch <dot@dotat.at> 2008-03-07 00:42:19 ---
Thanks for looking at this patch.

My original patch doesn't call ssh_control_listener() from
ssh_session() so I think you introduced that error. I believe the
control socket doesn't work with protocol version 1 because the latter
doesn't support arbitrary multiplexed streams. If so it's wrong to add
the call and wrong to re-arrange the code to make the call compile.

Thanks for spotting that the test argument is redundant.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1349


David Woodhouse <dwmw2@infradead.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1461|0 |1
is obsolete| |




--- Comment #5 from David Woodhouse <dwmw2@infradead.org> 2008-03-07 00:59:36 ---
Created an attachment (id=1462)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1462)
fixed patch

(In reply to comment #4)
> My original patch doesn't call ssh_control_listener() from
> ssh_session() so I think you introduced that error.

So I did; sorry. I was applying this patch after the patch in bug #1330
to provide 'ControlPersist' support, and had to fix up a reject by hand
-- incompetently, it would seem.

This one puts it back where it should be. But also applies _after_ Alan
Barrett's patch in bug #1330, which is hopefully also ready to be
applied now.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1349


Tony Finch <dot@dotat.at> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |dot@dotat.at




--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs