Mailing List Archive

Hi Amir

> On 16 May 2017, at 10:44, Amir Kaduri <akaduri75@gmail.com> wrote:
>
> Hello,
>
> I assume that I miss a minor detail, but I'll appreciate explaining
> how the following files are deployed in the right place on the machine
> when the pf_ring installation rpm is installed:
> 1. /usr/local/pfring/kernel/pf_ring.ko:
> In source file ../package/rpm/pfring.spec.in line 37, the copy
> command is commented out.

DKMS build and install the module when installing the package, I added some comments to the spec.
This is where the module should be installed by dkms:

/usr/lib/modules/`uname -r`/weak-updates/pf_ring.ko

> 2. /etc/systemd/system/pf_ring.service:
> The file itself appears in the source code under
> ../package/etc/systemd/system/pf_ring.service,
> but it doesn't appear in source file ../package/rpm/pfring.spec.in

Added to the spec (it was installed for ubuntu only)

Alfredo

>
> Thanks,
> Amir
> _______________________________________________
> Ntop-misc mailing list
> Ntop-misc@listgateway.unipi.it
> http://listgateway.unipi.it/mailman/listinfo/ntop-misc

Thanks for the prompt reply.
Amir

On Tue, May 16, 2017 at 12:09 PM, Alfredo Cardigliano
<cardigliano@ntop.org> wrote:
> Hi Amir
>
>> On 16 May 2017, at 10:44, Amir Kaduri <akaduri75@gmail.com> wrote:
>>
>> Hello,
>>
>> I assume that I miss a minor detail, but I'll appreciate explaining
>> how the following files are deployed in the right place on the machine
>> when the pf_ring installation rpm is installed:
>> 1. /usr/local/pfring/kernel/pf_ring.ko:
>> In source file ../package/rpm/pfring.spec.in line 37, the copy
>> command is commented out.
>
> DKMS build and install the module when installing the package, I added some comments to the spec.
> This is where the module should be installed by dkms:
>
> /usr/lib/modules/`uname -r`/weak-updates/pf_ring.ko
>
>> 2. /etc/systemd/system/pf_ring.service:
>> The file itself appears in the source code under
>> ../package/etc/systemd/system/pf_ring.service,
>> but it doesn't appear in source file ../package/rpm/pfring.spec.in
>
> Added to the spec (it was installed for ubuntu only)
>
> Alfredo
>
>>
>> Thanks,
>> Amir
>> _______________________________________________
>> Ntop-misc mailing list
>> Ntop-misc@listgateway.unipi.it
>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
>
>
> _______________________________________________
> Ntop-misc mailing list
> Ntop-misc@listgateway.unipi.it
> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
_______________________________________________
Ntop-misc mailing list
Ntop-misc@listgateway.unipi.it
http://listgateway.unipi.it/mailman/listinfo/ntop-misc

Apparently, systemd doesn't like that the pf_ring.service and
cluster.service files have executable bit set and keeps complaining in
/var/log/messages.
This is just a warning but it spams the file.
Example:
var/log/messages-20170521:May 21 07:28:18 localhost systemd:
Configuration file /etc/systemd/system/pf_ring.service is marked
executable. Please remove executable permission bits. Proceeding
anyway.

The executable bit is set probably due to my source-control system,
and probably not a problem that many will suffer from.

Still, you can consider changing command "cp" to "install -m 644" as follows:

In file package/rpm/pfring.spec.in:

From:
cp $HOME/PF_RING/package/etc/systemd/system/pf_ring.service
$RPM_BUILD_ROOT/etc/systemd/system
cp $HOME/PF_RING/package/etc/systemd/system/cluster.service
$RPM_BUILD_ROOT/etc/systemd/system

To:
install -m 644 $HOME/PF_RING/package/etc/systemd/system/pf_ring.service
$RPM_BUILD_ROOT/etc/systemd/system
install -m 644 $HOME/PF_RING/package/etc/systemd/system/cluster.service
$RPM_BUILD_ROOT/etc/systemd/system

Thanks,
Amir


On Wed, May 17, 2017 at 2:20 PM, Amir Kaduri <akaduri75@gmail.com> wrote:
> Thanks for the prompt reply.
> Amir
>
> On Tue, May 16, 2017 at 12:09 PM, Alfredo Cardigliano
> <cardigliano@ntop.org> wrote:
>> Hi Amir
>>
>>> On 16 May 2017, at 10:44, Amir Kaduri <akaduri75@gmail.com> wrote:
>>>
>>> Hello,
>>>
>>> I assume that I miss a minor detail, but I'll appreciate explaining
>>> how the following files are deployed in the right place on the machine
>>> when the pf_ring installation rpm is installed:
>>> 1. /usr/local/pfring/kernel/pf_ring.ko:
>>> In source file ../package/rpm/pfring.spec.in line 37, the copy
>>> command is commented out.
>>
>> DKMS build and install the module when installing the package, I added some comments to the spec.
>> This is where the module should be installed by dkms:
>>
>> /usr/lib/modules/`uname -r`/weak-updates/pf_ring.ko
>>
>>> 2. /etc/systemd/system/pf_ring.service:
>>> The file itself appears in the source code under
>>> ../package/etc/systemd/system/pf_ring.service,
>>> but it doesn't appear in source file ../package/rpm/pfring.spec.in
>>
>> Added to the spec (it was installed for ubuntu only)
>>
>> Alfredo
>>
>>>
>>> Thanks,
>>> Amir
>>> _______________________________________________
>>> Ntop-misc mailing list
>>> Ntop-misc@listgateway.unipi.it
>>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
>>
>>
>> _______________________________________________
>> Ntop-misc mailing list
>> Ntop-misc@listgateway.unipi.it
>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
_______________________________________________
Ntop-misc mailing list
Ntop-misc@listgateway.unipi.it
http://listgateway.unipi.it/mailman/listinfo/ntop-misc

Hi Amir
I double checked in our lab and pf_ring.service is installed without execution rights,
could you provide more details about your installation? I think you should fix something in your installation process.

Best Regards
Alfredo

> On 22 May 2017, at 10:23, Amir Kaduri <akaduri75@gmail.com> wrote:
>
> Apparently, systemd doesn't like that the pf_ring.service and
> cluster.service files have executable bit set and keeps complaining in
> /var/log/messages.
> This is just a warning but it spams the file.
> Example:
> var/log/messages-20170521:May 21 07:28:18 localhost systemd:
> Configuration file /etc/systemd/system/pf_ring.service is marked
> executable. Please remove executable permission bits. Proceeding
> anyway.
>
> The executable bit is set probably due to my source-control system,
> and probably not a problem that many will suffer from.
>
> Still, you can consider changing command "cp" to "install -m 644" as follows:
>
> In file package/rpm/pfring.spec.in:
>
> From:
> cp $HOME/PF_RING/package/etc/systemd/system/pf_ring.service
> $RPM_BUILD_ROOT/etc/systemd/system
> cp $HOME/PF_RING/package/etc/systemd/system/cluster.service
> $RPM_BUILD_ROOT/etc/systemd/system
>
> To:
> install -m 644 $HOME/PF_RING/package/etc/systemd/system/pf_ring.service
> $RPM_BUILD_ROOT/etc/systemd/system
> install -m 644 $HOME/PF_RING/package/etc/systemd/system/cluster.service
> $RPM_BUILD_ROOT/etc/systemd/system
>
> Thanks,
> Amir
>
>
> On Wed, May 17, 2017 at 2:20 PM, Amir Kaduri <akaduri75@gmail.com> wrote:
>> Thanks for the prompt reply.
>> Amir
>>
>> On Tue, May 16, 2017 at 12:09 PM, Alfredo Cardigliano
>> <cardigliano@ntop.org> wrote:
>>> Hi Amir
>>>
>>>> On 16 May 2017, at 10:44, Amir Kaduri <akaduri75@gmail.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> I assume that I miss a minor detail, but I'll appreciate explaining
>>>> how the following files are deployed in the right place on the machine
>>>> when the pf_ring installation rpm is installed:
>>>> 1. /usr/local/pfring/kernel/pf_ring.ko:
>>>> In source file ../package/rpm/pfring.spec.in line 37, the copy
>>>> command is commented out.
>>>
>>> DKMS build and install the module when installing the package, I added some comments to the spec.
>>> This is where the module should be installed by dkms:
>>>
>>> /usr/lib/modules/`uname -r`/weak-updates/pf_ring.ko
>>>
>>>> 2. /etc/systemd/system/pf_ring.service:
>>>> The file itself appears in the source code under
>>>> ../package/etc/systemd/system/pf_ring.service,
>>>> but it doesn't appear in source file ../package/rpm/pfring.spec.in
>>>
>>> Added to the spec (it was installed for ubuntu only)
>>>
>>> Alfredo
>>>
>>>>
>>>> Thanks,
>>>> Amir
>>>> _______________________________________________
>>>> Ntop-misc mailing list
>>>> Ntop-misc@listgateway.unipi.it
>>>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
>>>
>>>
>>> _______________________________________________
>>> Ntop-misc mailing list
>>> Ntop-misc@listgateway.unipi.it
>>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
> _______________________________________________
> Ntop-misc mailing list
> Ntop-misc@listgateway.unipi.it
> http://listgateway.unipi.it/mailman/listinfo/ntop-misc

Hi Alfredo,

You are correct, and this is exactly what I've tried to explain.
The origin of the problem is in the source-control system that I use,
and its probably not a problem in the spec file.

Since systemd is sensitive to the permissions of these file, I just
suggested maybe to copy them using "install -m 644" instead of "cp" to
make things easier for others in case they have similar problems.

If you don't think that it should be done like that in pfring.spec.in,
its a reasonable decision. No problem. Its just a suggestion.

Thanks,
Amir

On Tue, May 23, 2017 at 1:37 PM, Alfredo Cardigliano
<cardigliano@ntop.org> wrote:
> Hi Amir
> I double checked in our lab and pf_ring.service is installed without execution rights,
> could you provide more details about your installation? I think you should fix something in your installation process.
>
> Best Regards
> Alfredo
>
>> On 22 May 2017, at 10:23, Amir Kaduri <akaduri75@gmail.com> wrote:
>>
>> Apparently, systemd doesn't like that the pf_ring.service and
>> cluster.service files have executable bit set and keeps complaining in
>> /var/log/messages.
>> This is just a warning but it spams the file.
>> Example:
>> var/log/messages-20170521:May 21 07:28:18 localhost systemd:
>> Configuration file /etc/systemd/system/pf_ring.service is marked
>> executable. Please remove executable permission bits. Proceeding
>> anyway.
>>
>> The executable bit is set probably due to my source-control system,
>> and probably not a problem that many will suffer from.
>>
>> Still, you can consider changing command "cp" to "install -m 644" as follows:
>>
>> In file package/rpm/pfring.spec.in:
>>
>> From:
>> cp $HOME/PF_RING/package/etc/systemd/system/pf_ring.service
>> $RPM_BUILD_ROOT/etc/systemd/system
>> cp $HOME/PF_RING/package/etc/systemd/system/cluster.service
>> $RPM_BUILD_ROOT/etc/systemd/system
>>
>> To:
>> install -m 644 $HOME/PF_RING/package/etc/systemd/system/pf_ring.service
>> $RPM_BUILD_ROOT/etc/systemd/system
>> install -m 644 $HOME/PF_RING/package/etc/systemd/system/cluster.service
>> $RPM_BUILD_ROOT/etc/systemd/system
>>
>> Thanks,
>> Amir
>>
>>
>> On Wed, May 17, 2017 at 2:20 PM, Amir Kaduri <akaduri75@gmail.com> wrote:
>>> Thanks for the prompt reply.
>>> Amir
>>>
>>> On Tue, May 16, 2017 at 12:09 PM, Alfredo Cardigliano
>>> <cardigliano@ntop.org> wrote:
>>>> Hi Amir
>>>>
>>>>> On 16 May 2017, at 10:44, Amir Kaduri <akaduri75@gmail.com> wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> I assume that I miss a minor detail, but I'll appreciate explaining
>>>>> how the following files are deployed in the right place on the machine
>>>>> when the pf_ring installation rpm is installed:
>>>>> 1. /usr/local/pfring/kernel/pf_ring.ko:
>>>>> In source file ../package/rpm/pfring.spec.in line 37, the copy
>>>>> command is commented out.
>>>>
>>>> DKMS build and install the module when installing the package, I added some comments to the spec.
>>>> This is where the module should be installed by dkms:
>>>>
>>>> /usr/lib/modules/`uname -r`/weak-updates/pf_ring.ko
>>>>
>>>>> 2. /etc/systemd/system/pf_ring.service:
>>>>> The file itself appears in the source code under
>>>>> ../package/etc/systemd/system/pf_ring.service,
>>>>> but it doesn't appear in source file ../package/rpm/pfring.spec.in
>>>>
>>>> Added to the spec (it was installed for ubuntu only)
>>>>
>>>> Alfredo
>>>>
>>>>>
>>>>> Thanks,
>>>>> Amir
>>>>> _______________________________________________
>>>>> Ntop-misc mailing list
>>>>> Ntop-misc@listgateway.unipi.it
>>>>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
>>>>
>>>>
>>>> _______________________________________________
>>>> Ntop-misc mailing list
>>>> Ntop-misc@listgateway.unipi.it
>>>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
>> _______________________________________________
>> Ntop-misc mailing list
>> Ntop-misc@listgateway.unipi.it
>> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
>
>
> _______________________________________________
> Ntop-misc mailing list
> Ntop-misc@listgateway.unipi.it
> http://listgateway.unipi.it/mailman/listinfo/ntop-misc
_______________________________________________
Ntop-misc mailing list
Ntop-misc@listgateway.unipi.it
http://listgateway.unipi.it/mailman/listinfo/ntop-misc