Mailing List Archive

On Fri, 2 Jun 2023 at 22:48, David Engel <david@istwok.net> wrote:

> On Fri, May 19, 2023 at 02:35:34PM -0700, kmdewaal via mythtv-commits
> wrote:
> > Branch: refs/heads/master
> > Home: https://github.com/MythTV/mythtv
> > Commit: d54bb609dac731cee6315ad3d810c1d1edc6ced4
> >
> https://github.com/MythTV/mythtv/commit/d54bb609dac731cee6315ad3d810c1d1edc6ced4
> > Author: Klaas de Waal <klaas@kldo.nl>
> > Date: 2023-05-19 (Fri, 19 May 2023)
> >
> > Changed paths:
> > M mythtv/libs/libmythtv/tv_play.cpp
> >
> > Log Message:
> > -----------
> > Terminate Live TV channel input with SELECT
> >
> > In Live TV another channel can be selected by typing in the channel
> number.
> > The selection takes effect five seconds after the first character has
> been entered.
> > The channel number input can now be terminated by a SELECT action (the
> Enter key).
>
> Klaas, this commit breaks the exiting of fast-forward and rewind by
> pressing SELECT.


David, thanks for testing. Regressions should not happen of course.
Reverted this in commit 1594f64c7e705b7c87ac2b1ed9a954d7d2b144ef.


> Also, why is this commit necessary at all? Pressing
> SELECT has started a channel change for several years already.
>
> On my system the Enter key does not terminate live TV channel number input
and I have to wait for the timeout.
Lack of a way to terminate live TV channel number input has also been
reported on the mailing list a few months ago.
Could it be that there is a configuration setting that controls this
behavior?

Thanks,
Klaas.

On Sat, Jun 03, 2023 at 10:34:32AM +0200, Klaas de Waal wrote:
> On Fri, 2 Jun 2023 at 22:48, David Engel <david@istwok.net> wrote:
> > Also, why is this commit necessary at all? Pressing
> > SELECT has started a channel change for several years already.
> >
> > On my system the Enter key does not terminate live TV channel number input
> and I have to wait for the timeout.
> Lack of a way to terminate live TV channel number input has also been
> reported on the mailing list a few months ago.
> Could it be that there is a configuration setting that controls this
> behavior?

I'll check my own code. Maybe a local change has kept it working for
me. I know it worked many, many years ago. In fact, I suggested back
then to require the SELECT and Isaac vetoed it.

David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Sat, Jun 03, 2023 at 11:20:13AM -0500, David Engel wrote:
> On Sat, Jun 03, 2023 at 10:34:32AM +0200, Klaas de Waal wrote:
> > On Fri, 2 Jun 2023 at 22:48, David Engel <david@istwok.net> wrote:
> > > Also, why is this commit necessary at all? Pressing
> > > SELECT has started a channel change for several years already.
> > >
> > > On my system the Enter key does not terminate live TV channel number input
> > and I have to wait for the timeout.
> > Lack of a way to terminate live TV channel number input has also been
> > reported on the mailing list a few months ago.
> > Could it be that there is a configuration setting that controls this
> > behavior?
>
> I'll check my own code. Maybe a local change has kept it working for
> me. I know it worked many, many years ago. In fact, I suggested back
> then to require the SELECT and Isaac vetoed it.

It wasn't my code. It was my key bindings, sort of.

I believe the regression dates back to commit 5f9ddd6d. Before that
commit, pressing SELECT would call CommitQueuedInput() if applicable,
otherwise, it would set the bookmark. After that commit,
CommitQueuedInput() could only get called if the key was one of the
bookmark actions. I believe the correct fix is to move the
CommitQueuedInput() logic ahead of the BOOKMARK checks and explicitly
check for SELECT instead of any custom binding.

I didn't see this bug because I still have the legacy, key binding
which ties SELECT to SETBOOKMARK.

David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org