Mailing List Archive

Re: [mythtv-commits] [MythTV/mythtv] 769518: Rename v32-Pre -> v32-Branch.
FYI, the log message of a recent fixes/32 build shows still "v32-Pre" as
part of the identification, as shown here:
2022-02-02 12:18:31.811591 C mythbackend version: fixes/32
[v32-Pre-3493-g769518c4c6-dirty] www.mythtv.org

Previous versions do not have a "-Branch" suffix, as shown here for a
recent fixes/31:
2022-02-02 12:20:32.387755 C mythbackend version: fixes/31
[v31.0-167-g25f1bb1d12-dirty] www.mythtv.org

It looks like the string is created with the "git describe --dirty" command
and this uses the annotated tag. Which is then still v32-Pre if my
understanding is correct. Which then suggests that adding a tag is what
needs to be done.



On Tue, 1 Feb 2022 at 18:16, David Hampton via mythtv-commits <
mythtv-commits@mythtv.org> wrote:

> Branch: refs/heads/fixes/32
> Home: https://github.com/MythTV/mythtv
> Commit: 769518c4c69b35dd8470e4e1485dec2b15a924b6
>
> https://github.com/MythTV/mythtv/commit/769518c4c69b35dd8470e4e1485dec2b15a924b6
> Author: David Hampton <mythtv@love2code.net>
> Date: 2022-02-01 (Tue, 01 Feb 2022)
>
> Changed paths:
> M mythtv/SRC_VERSION
>
> Log Message:
> -----------
> Rename v32-Pre -> v32-Branch.
>
>
> _______________________________________________
> mythtv-commits mailing list
> mythtv-commits@mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-commits
>
Re: [mythtv-commits] [MythTV/mythtv] 769518: Rename v32-Pre -> v32-Branch. [ In reply to ]
On Wed, 2022-02-02 at 12:24 +0100, Klaas de Waal wrote:
> FYI, the log message of a recent fixes/32 build shows still "v32-Pre"
> as part of the identification, as shown here:
> 2022-02-02 12:18:31.811591 C  mythbackend version: fixes/32 [v32-Pre-
> 3493-g769518c4c6-dirty] www.mythtv.org
>
> Previous versions do not have a "-Branch" suffix, as shown here for a
> recent fixes/31:
> 2022-02-02 12:20:32.387755 C  mythbackend version: fixes/31 [v31.0-
> 167-g25f1bb1d12-dirty] www.mythtv.org
>
> It looks like the string is created with the "git describe --dirty"
> command and this uses the annotated tag. Which is then still v32-Pre
> if my understanding is correct. Which then suggests that adding a tag
> is what needs to be done.

I saw that too. If MythTV is built outside of a git repository, that's
when the file with the "v32-Branch" statement comes into play.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: [mythtv-commits] [MythTV/mythtv] 769518: Rename v32-Pre -> v32-Branch. [ In reply to ]
On Wed, 2022-02-02 at 12:24 +0100, Klaas de Waal wrote:
> FYI, the log message of a recent fixes/32 build shows still "v32-Pre"
> as part of the identification, as shown here:
> 2022-02-02 12:18:31.811591 C  mythbackend version: fixes/32 [v32-Pre-
> 3493-g769518c4c6-dirty] www.mythtv.org
>
> Previous versions do not have a "-Branch" suffix, as shown here for a
> recent fixes/31:
> 2022-02-02 12:20:32.387755 C  mythbackend version: fixes/31 [v31.0-
> 167-g25f1bb1d12-dirty] www.mythtv.org
>
> It looks like the string is created with the "git describe --dirty"
> command and this uses the annotated tag. Which is then still v32-Pre
> if my understanding is correct. Which then suggests that adding a tag
> is what needs to be done.

Agreed. Once v32 is released a tag will be added, and the version will
then show as v32.1 or whatever the tag name is.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org