#13633: Improve mythfilldatabase XMLTV logging
-------------------------------------------+--------------------------
Reporter: Gary Buhrmaster | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - Mythfilldatabase | Version: Master Head
Severity: medium | Keywords:
Ticket locked: 0 |
-------------------------------------------+--------------------------
Improve mythfilldatabase XMLTV logging
The intent of these patches is to improve logging, especially for those
converting from the legacy DataDirect service to the Schedules Direct
XMLTV service. It is hoped that this patch set be backported to fixes/31.
The changes have been separated into smaller pieces so that the designated
SME can more appropriately review the codes.
The changes are:
* Add what appears to be a missing logging message for the interrupted
grabber case.
* Remove a LOC identifier that is not used elsewhere for LOG_ERR messages
in mythfilldatabase.
* Invoke the running of the grabber such that the output is actually
captured and logged (the code implies (via header/trailer separators) that
at some time in the past the output was made available in the logs, but it
has not been so for some time).
* Change the loglevel in programdata to be the same as EIT updates (i.e.
debug). This also allows a run of "mythfilldatabase --verbose
general,xmltv" to not needlessly include messages about adding/deleting
actual programs (i.e. making the usage easier to review), but just include
the XMLTV logging that likely matters for the average use case.
FWIW, I initially used the new MythSystem rather than MythSystemLegacy for
the grabber invokation, but the rabbit hole for proper implementation
included implementing a TODO in MythSystem, and since it was a larger
update, would likely not be appropriate to backport. I'll look at the
TODO in MythSystem and converting mythfilldatabase at some later time.
Operational status: It is in the "works for me" phase (I am using the
entire set of patches with my own builds of MythTV).
Patches will be attached.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/13633>
MythTV <http://www.mythtv.org>
MythTV Media Center
-------------------------------------------+--------------------------
Reporter: Gary Buhrmaster | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - Mythfilldatabase | Version: Master Head
Severity: medium | Keywords:
Ticket locked: 0 |
-------------------------------------------+--------------------------
Improve mythfilldatabase XMLTV logging
The intent of these patches is to improve logging, especially for those
converting from the legacy DataDirect service to the Schedules Direct
XMLTV service. It is hoped that this patch set be backported to fixes/31.
The changes have been separated into smaller pieces so that the designated
SME can more appropriately review the codes.
The changes are:
* Add what appears to be a missing logging message for the interrupted
grabber case.
* Remove a LOC identifier that is not used elsewhere for LOG_ERR messages
in mythfilldatabase.
* Invoke the running of the grabber such that the output is actually
captured and logged (the code implies (via header/trailer separators) that
at some time in the past the output was made available in the logs, but it
has not been so for some time).
* Change the loglevel in programdata to be the same as EIT updates (i.e.
debug). This also allows a run of "mythfilldatabase --verbose
general,xmltv" to not needlessly include messages about adding/deleting
actual programs (i.e. making the usage easier to review), but just include
the XMLTV logging that likely matters for the average use case.
FWIW, I initially used the new MythSystem rather than MythSystemLegacy for
the grabber invokation, but the rabbit hole for proper implementation
included implementing a TODO in MythSystem, and since it was a larger
update, would likely not be appropriate to backport. I'll look at the
TODO in MythSystem and converting mythfilldatabase at some later time.
Operational status: It is in the "works for me" phase (I am using the
entire set of patches with my own builds of MythTV).
Patches will be attached.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/13633>
MythTV <http://www.mythtv.org>
MythTV Media Center