Mailing List Archive

cvs commit: modperl/src/modules/perl Tie.xs
rse 98/06/09 06:37:27

Modified: src/modules/perl Tie.xs
Log:
Under APACI the APACHE_SRC dir is not in the include path (no -I for this) and
thus Tie.xs only compiled when PERL_SSI was active (where -I$(SRCDIR) is
needed for mod_include - which cannot do it differenly). OTOH we can change
this to a local variant because all other sources are already this way:

Apache.xs:#include "mod_perl.h"
Constants.xs:#include "mod_perl.h"
Makefile:$(OBJS): mod_perl.h $(INCDIR)/httpd.h $(INCDIR)/http_config.h
ModuleConfig.xs:#include "mod_perl.h"
mod_perl.c:#include "mod_perl.h"
mod_perl.h:} mod_perl_handler;
mod_perl.h:SV *mod_perl_resolve_handler(request_rec *r, SV *sv,
mod_perl_handler *h);
mod_perl.h:mod_perl_handler *mod_perl_new_handler(request_rec *r, SV *sv);
perl_config.c:#include "mod_perl.h"
perl_util.c:#include "mod_perl.h"
perlio.c:#include "mod_perl.h"

So we break nothing and only gain a working APACI variant when
we subst modules/perl/mod_perl.h --> mod_perl.h for Tie.xs.

Revision Changes Path
1.4 +1 -1 modperl/src/modules/perl/Tie.xs

Index: Tie.xs
===================================================================
RCS file: /export/home/cvs/modperl/src/modules/perl/Tie.xs,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Tie.xs 1998/06/07 17:58:50 1.3
+++ Tie.xs 1998/06/09 13:37:27 1.4
@@ -1,4 +1,4 @@
-#include "modules/perl/mod_perl.h"
+#include "mod_perl.h"

typedef struct {
table *table;
Re: cvs commit: modperl/src/modules/perl Tie.xs [ In reply to ]
rse@hyperreal.org wrote:

> rse 98/06/09 06:37:27
>
> Modified: src/modules/perl Tie.xs
> Log:
> Under APACI the APACHE_SRC dir is not in the include path (no -I for this) and
> thus Tie.xs only compiled when PERL_SSI was active (where -I$(SRCDIR) is
> needed for mod_include - which cannot do it differenly). OTOH we can change
> this to a local variant because all other sources are already this way:
>
> Apache.xs:#include "mod_perl.h"
> Constants.xs:#include "mod_perl.h"
> Makefile:$(OBJS): mod_perl.h $(INCDIR)/httpd.h $(INCDIR)/http_config.h
> ModuleConfig.xs:#include "mod_perl.h"
> mod_perl.c:#include "mod_perl.h"
> mod_perl.h:} mod_perl_handler;
> mod_perl.h:SV *mod_perl_resolve_handler(request_rec *r, SV *sv,
> mod_perl_handler *h);
> mod_perl.h:mod_perl_handler *mod_perl_new_handler(request_rec *r, SV *sv);
> perl_config.c:#include "mod_perl.h"
> perl_util.c:#include "mod_perl.h"
> perlio.c:#include "mod_perl.h"
>
> So we break nothing and only gain a working APACI variant when
> we subst modules/perl/mod_perl.h --> mod_perl.h for Tie.xs.

Looks good. It was originally modules/perl/mod_perl.h when Apache::Tie
was outside the distribution, and Makefile.PL's INC was
Apache::src->new->inc

-Doug