Mailing List Archive

Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod
pgollucci@apache.org wrote:
> Author: pgollucci
> Date: Tue Sep 20 12:49:58 2005
> New Revision: 290549
>
> URL: http://svn.apache.org/viewcvs?rev=290549&view=rev
> Log:
> fix
> bin/build -f
>
> ----------------------------------------
> File: asf/perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod
> spurious '>' at <input text> line 4779
> spurious '>' at <input text> line 4779
>
>
>
> Modified:
> perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod
>
> Modified: perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod
> URL: http://svn.apache.org/viewcvs/perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod?rev=290549&r1=290548&r2=290549&view=diff
> ==============================================================================
> --- perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod (original)
> +++ perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod Tue Sep 20 12:49:58 2005
> @@ -180,7 +180,7 @@
>
> If you are going to write your own benchmarking utility, use the
> C<Benchmark> module and the C<Time::HiRes> module where you need
> -better time precision (<10msec).
> +better time precision (less than 10msec).
>
> An example of the C<Benchmark.pm> module usage:

So these two were the cause of the problem? I wonder why we haven't
received those "bugs" in first place? It used to work just fine.

--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Stas Bekman wrote:
> So these two were the cause of the problem? I wonder why we haven't
> received those "bugs" in first place? It used to work just fine.
Sadly no, these were just warnings I was able to see while building it without -v

I've tried 3-4 versions back taking the file (src/docs/2.0/porting/porting.pod) not the above changed one
(src/docs/1.0/guide/performance.pod) to ~April 4th. And it still doesn't work.

I'll have a little more time tonight, but I'm starting to run out of ideas.

Also, the html2ps which spawns gs (ghost script)

Does html2ps have any documentation?

i.e.e Among other questions, is the file position in the error message a byte position or character count ?





--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Philip M. Gollucci wrote:
> Stas Bekman wrote:
>
>> So these two were the cause of the problem? I wonder why we haven't
>> received those "bugs" in first place? It used to work just fine.
>
> Sadly no, these were just warnings I was able to see while building it
> without -v
>
> I've tried 3-4 versions back taking the file
> (src/docs/2.0/porting/porting.pod) not the above changed one
> (src/docs/1.0/guide/performance.pod) to ~April 4th. And it still
> doesn't work.

I've also updated lib/DocSet as you've sent to me and before that html2ps,
so that might be the cause as well. i.e try installing an older DocSet
module and nuke lib/DocSet so it won't use the local modules.

> I'll have a little more time tonight, but I'm starting to run out of ideas.
>
> Also, the html2ps which spawns gs (ghost script)
>
> Does html2ps have any documentation?

Only for user purposes (like config files)
http://user.it.uu.se/~jan/html2ps.html

> i.e.e Among other questions, is the file position in the error
> message a byte position or character count ?

I've no idea. html2ps is a very old perl4 app. Unfortunately I could find
anything better.

--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Stas Bekman wrote:
> I've also updated lib/DocSet as you've sent to me and before that
> html2ps, so that might be the cause as well. i.e try installing an older
> DocSet module and nuke lib/DocSet so it won't use the local modules.
Stas,
DocSet0.17 works, but DocSet0.18 Does not.

I may have sometime to dig through the diff Saturday morning.

--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Philip M. Gollucci wrote:
> Stas Bekman wrote:
>
>> I've also updated lib/DocSet as you've sent to me and before that
>> html2ps, so that might be the cause as well. i.e try installing an
>> older DocSet module and nuke lib/DocSet so it won't use the local
>> modules.
>
> Stas,
> DocSet0.17 works, but DocSet0.18 Does not.
>
> I may have sometime to dig through the diff Saturday morning.
>
Eurika!

This part of the upgrade causes it to fail, though I have no idea why (yet)

diff -u -bwi -ru DocSet-0.17/lib/DocSet/Doc/POD2HTMLPS.pm
DocSet-0.18/lib/DocSet/Doc/POD2HTMLPS.pm
--- DocSet-0.17/lib/DocSet/Doc/POD2HTMLPS.pm Thu Jun 13 05:06:21 2002
+++ DocSet-0.18/lib/DocSet/Doc/POD2HTMLPS.pm Fri Sep 2 15:19:00 2005
@@ -97,25 +97,25 @@

sub view_head1 {
my ($self, $head1) = @_;
- return "<h2>" . $self->anchor($head1->title) . "</h2>\n\n" .
+ return "<h2>" . $head1->title . "</h2>\n\n" .
$head1->content->present($self);
}

sub view_head2 {
my ($self, $head2) = @_;
- return "<h3>" . $self->anchor($head2->title) . "</h3>\n\n" .
+ return "<h3>" . $head2->title . "</h3>\n\n" .
$head2->content->present($self);
}

sub view_head3 {
my ($self, $head3) = @_;
- return "<h4>" . $self->anchor($head3->title) . "</h4>\n\n" .
+ return "<h4>" . $head3->title . "</h4>\n\n" .
$head3->content->present($self);
}

sub view_head4 {
my ($self, $head4) = @_;
- return "<h5>" . $self->anchor($head4->title) . "</h5>\n\n" .
+ return "<h5>" . $head4->title . "</h5>\n\n" .
$head4->content->present($self);
}


--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
sub pod_pom_html_view_seq_link_transform_path {
my ($self, $path) = @_;

$path =~ s|::|/|g;
my $doc_obj = get_render_obj();

my $res_path = $doc_obj->transform_src_doc($path);
unless ($res_path) {
# report broken links if we were told to
if (DocSet::RunTime::get_opts('validate_links')) {
print "!!! Broken link $doc_obj->{src_path}: [$path]\n";
}
return undef;
}

$res_path =~ s/\.[^.]+$/.html/;
# print "$res_path\n";
return $res_path;
}

Is busted in 0.18 ... hopefully someone more family with DocSet internals can
figure it out :)


--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Philip M. Gollucci wrote:
> Philip M. Gollucci wrote:
>
>> Stas Bekman wrote:
>>
>>> I've also updated lib/DocSet as you've sent to me and before that
>>> html2ps, so that might be the cause as well. i.e try installing an
>>> older DocSet module and nuke lib/DocSet so it won't use the local
>>> modules.
>>
>>
>> Stas,
>> DocSet0.17 works, but DocSet0.18 Does not.
>>
>> I may have sometime to dig through the diff Saturday morning.
>>
> Eurika!
>
> This part of the upgrade causes it to fail, though I have no idea why (yet)
>
> diff -u -bwi -ru DocSet-0.17/lib/DocSet/Doc/POD2HTMLPS.pm
> DocSet-0.18/lib/DocSet/Doc/POD2HTMLPS.pm
> --- DocSet-0.17/lib/DocSet/Doc/POD2HTMLPS.pm Thu Jun 13 05:06:21 2002
> +++ DocSet-0.18/lib/DocSet/Doc/POD2HTMLPS.pm Fri Sep 2 15:19:00 2005
> @@ -97,25 +97,25 @@
>
> sub view_head1 {
> my ($self, $head1) = @_;
> - return "<h2>" . $self->anchor($head1->title) . "</h2>\n\n" .
> + return "<h2>" . $head1->title . "</h2>\n\n" .
> $head1->content->present($self);
> }
>
> sub view_head2 {
> my ($self, $head2) = @_;
> - return "<h3>" . $self->anchor($head2->title) . "</h3>\n\n" .
> + return "<h3>" . $head2->title . "</h3>\n\n" .
> $head2->content->present($self);
> }
>
> sub view_head3 {
> my ($self, $head3) = @_;
> - return "<h4>" . $self->anchor($head3->title) . "</h4>\n\n" .
> + return "<h4>" . $head3->title . "</h4>\n\n" .
> $head3->content->present($self);
> }
>
> sub view_head4 {
> my ($self, $head4) = @_;
> - return "<h5>" . $self->anchor($head4->title) . "</h5>\n\n" .
> + return "<h5>" . $head4->title . "</h5>\n\n" .
> $head4->content->present($self);
> }

Cool,

I should have mentioned http://svn.perl.org/viewcvs/modules/DocSet/


--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Philip M. Gollucci wrote:
> sub pod_pom_html_view_seq_link_transform_path {
> my ($self, $path) = @_;
>
> $path =~ s|::|/|g;
> my $doc_obj = get_render_obj();
>
> my $res_path = $doc_obj->transform_src_doc($path);
> unless ($res_path) {
> # report broken links if we were told to
> if (DocSet::RunTime::get_opts('validate_links')) {
> print "!!! Broken link $doc_obj->{src_path}: [$path]\n";
> }
> return undef;
> }
>
> $res_path =~ s/\.[^.]+$/.html/;
> # print "$res_path\n";
> return $res_path;
> }
>
> Is busted in 0.18 ... hopefully someone more family with DocSet
> internals can figure it out :)

That would be me. What part is busted?


--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Stas Bekman wrote:
> I should have mentioned http://svn.perl.org/viewcvs/modules/DocSet/
I actually new about it, but was feeling lazy at 3am.

Speaking of which, why isn't it setup as an svn externals in the mp2 repo.

Better yet, why does it need to be there for convience anyway since we require Template Toolkit to build the
docs and we don't keep a copy in the repo?


--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
>> Is busted in 0.18 ... hopefully someone more family with DocSet
>> internals can figure it out :)
>
>
> That would be me. What part is busted?
I gave up at 3:14am.

I guessing that via anchor() calls, this function is generation incorrect html from the pod
which is then being read by html2ps (which is fine) and handed to ghostscript which chokes on the input
it was given.

I guess the logical next step is to generate porting.html from porting.pod with 0.17 and 0.18 and then diff them?



--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Philip M. Gollucci wrote:
> Stas Bekman wrote:
>
>> I should have mentioned http://svn.perl.org/viewcvs/modules/DocSet/
>
> I actually new about it, but was feeling lazy at 3am.

> Speaking of which, why isn't it setup as an svn externals in the mp2 repo.

Because

1) it doesn't live on apache.org
2) because it's a production site and it shouldn't have un-released sw (in
this case it was obviously my screw-up)

> Better yet, why does it need to be there for convience anyway since we
> require Template Toolkit to build the docs and we don't keep a copy in the repo?

I guess it is to ensure that things always work?


--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Philip M. Gollucci wrote:
>>> Is busted in 0.18 ... hopefully someone more family with DocSet
>>> internals can figure it out :)
>
> I guessing that via anchor() calls, this function is generation
> incorrect html from the pod
> which is then being read by html2ps (which is fine) and handed to
> ghostscript which chokes on the input
> it was given.
>
> I guess the logical next step is to generate porting.html from
> porting.pod with 0.17 and 0.18 and then diff them?

Now, I'm really confused:

diff porting.html_0.17 porting.html_0.18
--- porting.html_0.17 Sun Sep 25 09:46:14 2005
+++ porting.html_0.18 Sun Sep 25 09:47:11 2005
@@ -2515,7 +2515,7 @@
<div class="footer noPrint">
<hr noshade size="1">
<!-- footer (tail )-->
- <p class="modified">Last modified Sun Sep 25 09:45:32 2005</p>
+ <p class="modified">Last modified Sun Sep 25 09:46:43 2005</p>
<div class="changes"><a href="../Changes.html"><img
src="../../../../images/nav/page_changes.gif" width="60" height="16" border="0"
alt="Changes file"></a>
<br><br>
</div>

So the only difference in the generated html being fed to html2ps is the above
but yet 0.17 works and 0.18 doesn't. I've interchanged html2ps seperately from
each version and it works with both.....

Any great ideas ?



--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
[...]

The bug is in the POD not being completely translated into HTML. in
porting.html html2ps crashes here:

<h5>I<Apache/MP3.pm></h5>

i.e. I<> wasn't converted

I'm looking at it.

--
_______________________________________________________________
Stas Bekman mailto:stas@stason.org | http://stason.org/
MailChannels: Assured Messaging (TM) | http://mailchannels.com/
The "Practical mod_perl" book | http://modperlbook.org/


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: svn commit: r290549 - /perl/modperl/docs/trunk/src/docs/1.0/guide/performance.pod [ In reply to ]
Stas Bekman wrote:
> [...]
>
> The bug is in the POD not being completely translated into HTML. in
> porting.html html2ps crashes here:
>
> <h5>I<Apache/MP3.pm></h5>
>
> i.e. I<> wasn't converted
>
> I'm looking at it.

Now fixed.

Thanks for investigating the issue, Philip! That was very helpful.

The problem was that the title wasn't parsed and any POD markup in it
wasn't getting converted to HTML's equivalent. Fixed by:

- return "<h2>" . $head1->title . "</h2>\n\n" .
+ return "<h2>" . $head1->title->present($self) . "</h2>\n\n" .

in 0.17 it was passed to anchor() which has happened to render the title
besides other things.

--
_______________________________________________________________
Stas Bekman mailto:stas@stason.org | http://stason.org/
MailChannels: Assured Messaging (TM) | http://mailchannels.com/
The "Practical mod_perl" book | http://modperlbook.org/


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org