Mailing List Archive

Philip M. Gollucci wrote:
> The corresponding update for the docs tree
>
> my (
> vs
> my(
>
> note, there are some cases of
> my ( $var
> that this changes to
> my( $var
> whats the opinion on those ?
>
> See attached.

DocSet (the stuff under lib/) is not part of the modperl-docs. It's there
just to make the docs repository self-contained. It's actually living on
my machine and it's a CPAN module. So I'll need to apply this to my
repository first and then I'll resync the convenience copy under lib next.

+1 to the most of the rest. See some comments below:

While you are at it, please add more spaces as follows:

Index: src/docs/2.0/devel/core/coding_style.pod
===================================================================
--- src/docs/2.0/devel/core/coding_style.pod (revision 219272)
+++ src/docs/2.0/devel/core/coding_style.pod (working copy)
@@ -93,7 +93,7 @@

sub foo
{
- my ($self,$bar,$baz,$taz)=@_;
+ my($self,$bar,$baz,$taz) = @_;

This patch seems to be wrong:

Index: src/docs/2.0/rename.pod
===================================================================
--- src/docs/2.0/rename.pod (revision 219272)
+++ src/docs/2.0/rename.pod (working copy)
@@ -186,7 +186,7 @@
The directions for
L<installing mod_perl 2.0 |docs::2.0::user::install::install>.
Help is also available through the archives of and subscribing to
-the L<mod_perl mailing list|maillist::modperl>.
+the L<mod_perl mailing list|maillist::moduli>.

So does this. Please don't modify code while doing style changes:

Index: src/docs/2.0/user/porting/code/apache_mp3_2.diff
===================================================================
--- src/docs/2.0/user/porting/code/apache_mp3_2.diff (revision 219272)
+++ src/docs/2.0/user/porting/code/apache_mp3_2.diff (working copy)
@@ -45,7 +45,7 @@
@@ -1340,7 +1348,7 @@
sub get_dir {
my $self = shift;
- my ($config,$default) = @_;
+ my($config,$default) = @_;
- my $dir = $self->r->dir_config($config) || $default;
+ my $dir = $self->get_config($config) || $default;
return $dir if $dir =~ m!^/!; # looks like a path

Same for: src/docs/2.0/user/porting/code/apache_mp3_7.diff
src/docs/tutorials/tips/mod_perl_tricks/mod_perl_tricks.pod

(code changes must be committed separately)

===========

src/search is Bill Moseley's code, which again under svn for convenience
reasons. I'm not sure what's the best way to go about it. I guess just
leave it as it is, so Bill won't need to figure out what has changed when
updating it.

--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org