gozer@apache.org wrote:
> gozer 2004/08/10 11:13:24
[...]
Thanks for working on these, Philippe. There are a few nuances though :)
> =head2 C<cmds>
>
> -META: Autogenerated - needs to be reviewed/completed
> -
> -A command_rec table that describes all of the directives this module
> +An Apache::Command table that describes all of the directives this module
> defines.
>
> $cmd_rec = $module->cmds();
this doc entry is incomplete. this method is get/set but the doc
documents only the get functionality. Please compare against .xs file
and make sure that all possible invocations are documented and (mostly)
tested, before a module can be considered complete.
I haven't looked through other methods of this module and the other
modules yet. So if you can take a look and finish them off that would be
great. Let me know when this is done, and I'll review these then.
Thanks.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
> gozer 2004/08/10 11:13:24
[...]
Thanks for working on these, Philippe. There are a few nuances though :)
> =head2 C<cmds>
>
> -META: Autogenerated - needs to be reviewed/completed
> -
> -A command_rec table that describes all of the directives this module
> +An Apache::Command table that describes all of the directives this module
> defines.
>
> $cmd_rec = $module->cmds();
this doc entry is incomplete. this method is get/set but the doc
documents only the get functionality. Please compare against .xs file
and make sure that all possible invocations are documented and (mostly)
tested, before a module can be considered complete.
I haven't looked through other methods of this module and the other
modules yet. So if you can take a look and finish them off that would be
great. Let me know when this is done, and I'll review these then.
Thanks.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org