Mailing List Archive

Patches are always welcome, please feel free to patch as you see fit :)

On Fri, Nov 23, 2012 at 3:35 AM, Andrew Beverley <andy@andybev.com> wrote:
> Hi,
>
> I'm a new user of mod_perl, and I'm about to work on a few documentation
> patches as a result of some initial frustrations.
>
> I was going to submit some minor updates to the "Sometimes it Works,
> Sometimes it Doesn't" area in both the porting and debug sections.
>
> However, I've just noticed that this section doesn't even appear in the
> v2 documentation. Is there a reason for this? If not, can I provide a
> patch to add it in?
>
> Thanks,
>
> Andy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: docs-dev-help@perl.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org

On Fri, 2012-11-23 at 11:38 -0800, Fred Moyer wrote:
> Patches are always welcome, please feel free to patch as you see fit :)

I sent a patch through a while ago. Is somebody able to review please?

<http://mail-archives.apache.org/mod_mbox/perl-docs-dev/201211.mbox/%3C1353966876.1779.13.camel%40andrew-desktop%3E>

Thanks,

Andy



---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org

On Sat, Dec 8, 2012 at 2:55 AM, Andrew Beverley <andy@andybev.com> wrote:
> On Fri, 2012-11-23 at 11:38 -0800, Fred Moyer wrote:
>> Patches are always welcome, please feel free to patch as you see fit :)
>
> I sent a patch through a while ago. Is somebody able to review please?

Just took a look at it. Can you remove the carriage returns in your
patch? Other than that I think the content looks pretty good.


diff -rupN modperl-docs.orig/src/docs/2.0/user/troubleshooting/troubleshooting.pod
modperl-docs.sometimes/src/docs/2.0/user/troubleshooting/troubleshooting.pod^M
--- modperl-docs.orig/src/docs/2.0/user/troubleshooting/troubleshooting.pod
2012-11-24 13:28:27.294345909 +0000^M
+++ modperl-docs.sometimes/src/docs/2.0/user/troubleshooting/troubleshooting.pod
2012-11-25 19:50:10.264734329 +0000^M
@@ -675,6 +675,158 @@ when you encounter this problem.^M
^M
^M
^M
+=head2 Variable $x will not stay shared at^M
+^M



>
> <http://mail-archives.apache.org/mod_mbox/perl-docs-dev/201211.mbox/%3C1353966876.1779.13.camel%40andrew-desktop%3E>
>
> Thanks,
>
> Andy
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org

On Sat, 2012-12-08 at 22:53 -0800, Fred Moyer wrote:
> On Sat, Dec 8, 2012 at 2:55 AM, Andrew Beverley <andy@andybev.com> wrote:
> > On Fri, 2012-11-23 at 11:38 -0800, Fred Moyer wrote:
> >> Patches are always welcome, please feel free to patch as you see fit :)
> >
> > I sent a patch through a while ago. Is somebody able to review please?
>
> Just took a look at it. Can you remove the carriage returns in your
> patch?

Hmmm, strange, not sure where they came from, they weren't in the file
on my computer. I've reattached as a .gz to try and stop that happening
again.

> Other than that I think the content looks pretty good.

Great, thanks for reviewing.

Andy

Patch applied, thanks.

Committed revision 1419195.

On Sun, Dec 9, 2012 at 9:15 AM, Andrew Beverley <andy@andybev.com> wrote:
> On Sat, 2012-12-08 at 22:53 -0800, Fred Moyer wrote:
>> On Sat, Dec 8, 2012 at 2:55 AM, Andrew Beverley <andy@andybev.com> wrote:
>> > On Fri, 2012-11-23 at 11:38 -0800, Fred Moyer wrote:
>> >> Patches are always welcome, please feel free to patch as you see fit :)
>> >
>> > I sent a patch through a while ago. Is somebody able to review please?
>>
>> Just took a look at it. Can you remove the carriage returns in your
>> patch?
>
> Hmmm, strange, not sure where they came from, they weren't in the file
> on my computer. I've reattached as a .gz to try and stop that happening
> again.
>
>> Other than that I think the content looks pretty good.
>
> Great, thanks for reviewing.
>
> Andy
>

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org