Mailing List Archive: First time contribution

First time contribution

Mar 23, 2023, 9:58 AM

Post #1 of 6 (260 views)

Hi!

My name is Frederic Thevenet and I am the maintainer of a FOSS time
series browser and log viewer tool called binjr [0] which uses Lucene to
do some pretty neat things.

As part of that, I became aware of a raster nasty bug that would cause
searches made via DrillSideways miss documents that should match the
query [1].
After (a lot) of digging I believe I found the issue and therefore
submitted a PR to hopefully fix it[2].

This is my first attempt at contributing to this project and although I
did read the contribution guidelines over on github, it didn't seem to
contain much, other than opening a PR.

So I thought I'd start with a short introduction here, thinking it
wouldn't hurt :-)

Please let me know if I have missed anything, and looking forward to
getting a review on that PR.

--
Cheers,
Frederic

[0] https://github.com/binjr/binjr
[1] https://github.com/apache/lucene/issues/12211
[2] https://github.com/apache/lucene/pull/12212

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: First time contribution [ In reply to ]

lucene at mikemccandless

Mar 23, 2023, 11:51 AM

Post #2 of 6 (260 views)

Permalink

Thank you Frederic! Welcome, and it's great to e-meet you.

Debugging DrillSideways must've been great fun ;)

Mike McCandless

http://blog.mikemccandless.com

On Thu, Mar 23, 2023 at 1:36?PM Frederic Thevenet <thevenet.fred@free.fr>
wrote:

> Hi!
>
> My name is Frederic Thevenet and I am the maintainer of a FOSS time
> series browser and log viewer tool called binjr [0] which uses Lucene to
> do some pretty neat things.
>
> As part of that, I became aware of a raster nasty bug that would cause
> searches made via DrillSideways miss documents that should match the
> query [1].
> After (a lot) of digging I believe I found the issue and therefore
> submitted a PR to hopefully fix it[2].
>
> This is my first attempt at contributing to this project and although I
> did read the contribution guidelines over on github, it didn't seem to
> contain much, other than opening a PR.
>
> So I thought I'd start with a short introduction here, thinking it
> wouldn't hurt :-)
>
> Please let me know if I have missed anything, and looking forward to
> getting a review on that PR.
>
> --
> Cheers,
> Frederic
>
> [0] https://github.com/binjr/binjr
> [1] https://github.com/apache/lucene/issues/12211
> [2] https://github.com/apache/lucene/pull/12212
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: First time contribution [ In reply to ]

lucene at mikemccandless

Mar 23, 2023, 11:54 AM

Post #3 of 6 (260 views)

Permalink

Re: First time contribution [ In reply to ]

thevenet.fred at free

Mar 23, 2023, 1:09 PM

Post #4 of 6 (260 views)

Permalink

Thanks Michael!

Well yeah, it did take me a couple of late night hacking sessions to get
to the bottom of this one!
The fact that all I got to show for my efforts is literally *a single
word* change, is both disheartening and kinda brilliant at the same
time ;-)

--
Cheers,
Frederic

On 23/03/2023 19:51, Michael McCandless wrote:
> Thank you Frederic! Welcome, and it's great to e-meet you.
>
> Debugging DrillSideways must've been great fun ;)
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Thu, Mar 23, 2023 at 1:36?PM Frederic Thevenet
> <thevenet.fred@free.fr> wrote:
>
> Hi!
>
> My name is Frederic Thevenet and I am the maintainer of a FOSS time
> series browser and log viewer tool called binjr [0] which uses
> Lucene to
> do some pretty neat things.
>
> As part of that, I became aware of a raster nasty bug that would
> cause
> searches made via DrillSideways miss documents that should match the
> query [1].
> After (a lot) of digging I believe I found the issue and therefore
> submitted a PR to hopefully fix it[2].
>
> This is my first attempt at contributing to this project and
> although I
> did read the contribution guidelines over on github, it didn't
> seem to
> contain much, other than opening a PR.
>
> So I thought I'd start with a short introduction here, thinking it
> wouldn't hurt :-)
>
> Please let me know if I have missed anything, and looking forward to
> getting a review on that PR.
>
> --
> Cheers,
> Frederic
>
> [0] https://github.com/binjr/binjr
> [1] https://github.com/apache/lucene/issues/12211
> [2] https://github.com/apache/lucene/pull/12212
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

Re: First time contribution [ In reply to ]

lucene at mikemccandless

Mar 23, 2023, 1:22 PM

Post #5 of 6 (260 views)

Permalink

Ahhh the best bugs come down to tiny fixes! It could have been worse: it
could have been a single character fix ;)

Mike McCandless

http://blog.mikemccandless.com

On Thu, Mar 23, 2023 at 4:09?PM Frederic Thevenet <thevenet.fred@free.fr>
wrote:

> Thanks Michael!
>
> Well yeah, it did take me a couple of late night hacking sessions to get
> to the bottom of this one!
> The fact that all I got to show for my efforts is literally *a single
> word* change, is both disheartening and kinda brilliant at the same time
> ;-)
>
> --
> Cheers,
> Frederic
>
> On 23/03/2023 19:51, Michael McCandless wrote:
>
> Thank you Frederic! Welcome, and it's great to e-meet you.
>
> Debugging DrillSideways must've been great fun ;)
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Thu, Mar 23, 2023 at 1:36?PM Frederic Thevenet <thevenet.fred@free.fr>
> wrote:
>
>> Hi!
>>
>> My name is Frederic Thevenet and I am the maintainer of a FOSS time
>> series browser and log viewer tool called binjr [0] which uses Lucene to
>> do some pretty neat things.
>>
>> As part of that, I became aware of a raster nasty bug that would cause
>> searches made via DrillSideways miss documents that should match the
>> query [1].
>> After (a lot) of digging I believe I found the issue and therefore
>> submitted a PR to hopefully fix it[2].
>>
>> This is my first attempt at contributing to this project and although I
>> did read the contribution guidelines over on github, it didn't seem to
>> contain much, other than opening a PR.
>>
>> So I thought I'd start with a short introduction here, thinking it
>> wouldn't hurt :-)
>>
>> Please let me know if I have missed anything, and looking forward to
>> getting a review on that PR.
>>
>> --
>> Cheers,
>> Frederic
>>
>> [0] https://github.com/binjr/binjr
>> [1] https://github.com/apache/lucene/issues/12211
>> [2] https://github.com/apache/lucene/pull/12212
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>

Re: First time contribution [ In reply to ]

gsmiller at gmail

Mar 27, 2023, 5:11 PM

Post #6 of 6 (258 views)

Permalink

I've said this in the PR to some degree, but wanted to also respond here:

+1 to everything Mike said. THANK YOU for the debugging, filing a super
thorough bug report and PR for a fix. DrillSideways is not the easiest
place to start with Lucene, and kudos for jumping right into it! Great to
see another active participant in Lucene (and in faceting / DrillSideways)!

Cheers,
-Greg

On Thu, Mar 23, 2023 at 1:23?PM Michael McCandless <
lucene@mikemccandless.com> wrote:

> Ahhh the best bugs come down to tiny fixes! It could have been worse: it
> could have been a single character fix ;)
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Thu, Mar 23, 2023 at 4:09?PM Frederic Thevenet <thevenet.fred@free.fr>
> wrote:
>
>> Thanks Michael!
>>
>> Well yeah, it did take me a couple of late night hacking sessions to get
>> to the bottom of this one!
>> The fact that all I got to show for my efforts is literally *a single
>> word* change, is both disheartening and kinda brilliant at the same time
>> ;-)
>>
>> --
>> Cheers,
>> Frederic
>>
>> On 23/03/2023 19:51, Michael McCandless wrote:
>>
>> Thank you Frederic! Welcome, and it's great to e-meet you.
>>
>> Debugging DrillSideways must've been great fun ;)
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Thu, Mar 23, 2023 at 1:36?PM Frederic Thevenet <thevenet.fred@free.fr>
>> wrote:
>>
>>> Hi!
>>>
>>> My name is Frederic Thevenet and I am the maintainer of a FOSS time
>>> series browser and log viewer tool called binjr [0] which uses Lucene to
>>> do some pretty neat things.
>>>
>>> As part of that, I became aware of a raster nasty bug that would cause
>>> searches made via DrillSideways miss documents that should match the
>>> query [1].
>>> After (a lot) of digging I believe I found the issue and therefore
>>> submitted a PR to hopefully fix it[2].
>>>
>>> This is my first attempt at contributing to this project and although I
>>> did read the contribution guidelines over on github, it didn't seem to
>>> contain much, other than opening a PR.
>>>
>>> So I thought I'd start with a short introduction here, thinking it
>>> wouldn't hurt :-)
>>>
>>> Please let me know if I have missed anything, and looking forward to
>>> getting a review on that PR.
>>>
>>> --
>>> Cheers,
>>> Frederic
>>>
>>> [0] https://github.com/binjr/binjr
>>> [1] https://github.com/apache/lucene/issues/12211
>>> [2] https://github.com/apache/lucene/pull/12212
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
>>