Mailing List Archive: Circuit Breaker Clean-up/Extension Jira

Circuit Breaker Clean-up/Extension Jira

Feb 14, 2021, 9:35 AM

Post #1 of 5 (336 views)

Please review for 8.9. We will use this feature after it is updated. The current circuit breakers won’t work for us.

https://issues.apache.org/jira/browse/SOLR-15056

This change:

* Preserves existing functionality.
* Renames the existing load average circuit breaker to a more accurate name.
* Adds a circuit breaker for CPU usage that is available if the JVM supports it.
* Adds detail to documentation, listing which JMX calls each circuit breaker is based on.
* Copy-edits on docs for more detail, less complicated wording (good when English is not the reader’s primary language)
* Includes unit tests.

wunder
Walter Underwood
wunder@wunderwood.org
http://observer.wunderwood.org/ (my blog)

Re: Circuit Breaker Clean-up/Extension Jira [ In reply to ]

atri at apache

Feb 14, 2021, 9:52 AM

Post #2 of 5 (336 views)

Permalink

Apologies for the delay. I will review this tomorrow

On Sun, 14 Feb 2021, 23:06 Walter Underwood, <wunder@wunderwood.org> wrote:

> Please review for 8.9. We will use this feature after it is updated. The
> current circuit breakers won’t work for us.
>
> https://issues.apache.org/jira/browse/SOLR-15056
>
> This change:
>
> * Preserves existing functionality.
> * Renames the existing load average circuit breaker to a more accurate
> name.
> * Adds a circuit breaker for CPU usage that is available if the JVM
> supports it.
> * Adds detail to documentation, listing which JMX calls each circuit
> breaker is based on.
> * Copy-edits on docs for more detail, less complicated wording (good when
> English is not the reader’s primary language)
> * Includes unit tests.
>
> wunder
> Walter Underwood
> wunder@wunderwood.org
> http://observer.wunderwood.org/ (my blog)
>
>

Re: Circuit Breaker Clean-up/Extension Jira [ In reply to ]

atri at apache

Feb 14, 2021, 9:56 AM

Post #3 of 5 (336 views)

Permalink

Also, if you could open a PR, it would be easier to review.

On Sun, 14 Feb 2021, 23:22 Atri Sharma, <atri@apache.org> wrote:

> Apologies for the delay. I will review this tomorrow
>
> On Sun, 14 Feb 2021, 23:06 Walter Underwood, <wunder@wunderwood.org>
> wrote:
>
>> Please review for 8.9. We will use this feature after it is updated. The
>> current circuit breakers won’t work for us.
>>
>> https://issues.apache.org/jira/browse/SOLR-15056
>>
>> This change:
>>
>> * Preserves existing functionality.
>> * Renames the existing load average circuit breaker to a more accurate
>> name.
>> * Adds a circuit breaker for CPU usage that is available if the JVM
>> supports it.
>> * Adds detail to documentation, listing which JMX calls each circuit
>> breaker is based on.
>> * Copy-edits on docs for more detail, less complicated wording (good when
>> English is not the reader’s primary language)
>> * Includes unit tests.
>>
>> wunder
>> Walter Underwood
>> wunder@wunderwood.org
>> http://observer.wunderwood.org/ (my blog)
>>
>>

Re: Circuit Breaker Clean-up/Extension Jira [ In reply to ]

wunder at wunderwood

Feb 14, 2021, 10:16 AM

Post #4 of 5 (336 views)

Permalink

Sorry, couldn’t figure out how to do that for Solr. I do PRs all day on our company system, but that uses Bitbucket.

The “how to contribute” docs just said to make a PR, which didn’t really help. I tried, but nothing worked.

wunder
Walter Underwood
wunder@wunderwood.org
http://observer.wunderwood.org/ (my blog)

> On Feb 14, 2021, at 9:56 AM, Atri Sharma <atri@apache.org> wrote:
>
> Also, if you could open a PR, it would be easier to review.
>
> On Sun, 14 Feb 2021, 23:22 Atri Sharma, <atri@apache.org <mailto:atri@apache.org>> wrote:
> Apologies for the delay. I will review this tomorrow
>
> On Sun, 14 Feb 2021, 23:06 Walter Underwood, <wunder@wunderwood.org <mailto:wunder@wunderwood.org>> wrote:
> Please review for 8.9. We will use this feature after it is updated. The current circuit breakers won’t work for us.
>
> https://issues.apache.org/jira/browse/SOLR-15056 <https://issues.apache.org/jira/browse/SOLR-15056>
>
> This change:
>
> * Preserves existing functionality.
> * Renames the existing load average circuit breaker to a more accurate name.
> * Adds a circuit breaker for CPU usage that is available if the JVM supports it.
> * Adds detail to documentation, listing which JMX calls each circuit breaker is based on.
> * Copy-edits on docs for more detail, less complicated wording (good when English is not the reader’s primary language)
> * Includes unit tests.
>
> wunder
> Walter Underwood
> wunder@wunderwood.org <mailto:wunder@wunderwood.org>
> http://observer.wunderwood.org/ <http://observer.wunderwood.org/> (my blog)
>

Re: Circuit Breaker Clean-up/Extension Jira [ In reply to ]

atri at apache

Feb 14, 2021, 10:27 AM

Post #5 of 5 (336 views)

Permalink

If you have a github account, you can fork Lucene/Solr repository, create a
branch in your fork, push your changes there and navigate to the Github
page of your fork which will provide you a button to create a PR.

On Sun, 14 Feb 2021, 23:46 Walter Underwood, <wunder@wunderwood.org> wrote:

> Sorry, couldn’t figure out how to do that for Solr. I do PRs all day on
> our company system, but that uses Bitbucket.
>
> The “how to contribute” docs just said to make a PR, which didn’t really
> help. I tried, but nothing worked.
>
> wunder
> Walter Underwood
> wunder@wunderwood.org
> http://observer.wunderwood.org/ (my blog)
>
> On Feb 14, 2021, at 9:56 AM, Atri Sharma <atri@apache.org> wrote:
>
> Also, if you could open a PR, it would be easier to review.
>
> On Sun, 14 Feb 2021, 23:22 Atri Sharma, <atri@apache.org> wrote:
>
>> Apologies for the delay. I will review this tomorrow
>>
>> On Sun, 14 Feb 2021, 23:06 Walter Underwood, <wunder@wunderwood.org>
>> wrote:
>>
>>> Please review for 8.9. We will use this feature after it is updated. The
>>> current circuit breakers won’t work for us.
>>>
>>> https://issues.apache.org/jira/browse/SOLR-15056
>>>
>>> This change:
>>>
>>> * Preserves existing functionality.
>>> * Renames the existing load average circuit breaker to a more accurate
>>> name.
>>> * Adds a circuit breaker for CPU usage that is available if the JVM
>>> supports it.
>>> * Adds detail to documentation, listing which JMX calls each circuit
>>> breaker is based on.
>>> * Copy-edits on docs for more detail, less complicated wording (good
>>> when English is not the reader’s primary language)
>>> * Includes unit tests.
>>>
>>> wunder
>>> Walter Underwood
>>> wunder@wunderwood.org
>>> http://observer.wunderwood.org/ (my blog)
>>>
>>>
>