Mailing List Archive

Little improvement for SimpleHTMLEncoder
Hi all!

The SimpleHTMLEncoder could be improved slightly: all characters with
code >= 128 should be encoded as character entities. The reason is, that
the encoder does not know the encoding that is used for the response.
Therefore it is safer to encode all characters beyond ASCII as character
entities. Can someone judge this proposal and commit it eventually?

Greetings!
--Stefan


default:
if (c < 128) {
result.append(c);
} else {
result.append("&#").append((int)c).append(";");
}
Re: Little improvement for SimpleHTMLEncoder [ In reply to ]
Could you add this to a Bugzilla issue so it doesn't get lost in the
never ending pile of e-mail that we all have?

Thanks,
Erik

On Aug 23, 2005, at 11:16 AM, Stefan Wachter wrote:

> Hi all!
>
> The SimpleHTMLEncoder could be improved slightly: all characters
> with code >= 128 should be encoded as character entities. The
> reason is, that the encoder does not know the encoding that is used
> for the response. Therefore it is safer to encode all characters
> beyond ASCII as character entities. Can someone judge this proposal
> and commit it eventually?
>
> Greetings!
> --Stefan
>
>
> default:
> if (c < 128) {
> result.append(c);
> } else {
> result.append("&#").append((int)c).append(";");
> }
>
>