Mailing List Archive: different meta data for different mysql-proxy versions

different meta data for different mysql-proxy versions

May 14, 2012, 8:02 AM

Post #1 of 3 (1259 views)

hi!

there have been some changes to mysql-proxy in version 0.8.1 and
0.8.2 that affect its required parameters:

0.8.1:
> Admin Plugin
> * removed the default values for --admin-username and --admin-password
> * enforce --admin-username, --admin-password and --admin-lua-script to be set
> if the admin plugin is loaded (#53429)

0.8.2:
> * removed the "admin" plugin from the list of plugins loaded by default

I therefore would check the version of mysql-proxy and would
vary the output of the meta data accordingly, e.g. (pseudocode)

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
ocf_version_cmp "$version" "0.8.1"
ret=$?

if [ $ret -eq 1 ]; then
required=1
else
required=0
fi

..
echo <parameter name="admin_username" unique="0" required="$required">

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Would you consider this a proper way of handling such requirements
or should i simply set required="0" and handle the special
cases via some validate_all() method?

Thanks,
Raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: different meta data for different mysql-proxy versions [ In reply to ]

dejan at suse

May 14, 2012, 8:21 AM

Post #2 of 3 (1245 views)

Permalink

Hi Raoul,

On Mon, May 14, 2012 at 05:02:40PM +0200, Raoul Bhatia [IPAX] wrote:
> hi!
>
> there have been some changes to mysql-proxy in version 0.8.1 and
> 0.8.2 that affect its required parameters:
>
> 0.8.1:
> > Admin Plugin
> > * removed the default values for --admin-username and --admin-password
> > * enforce --admin-username, --admin-password and --admin-lua-script to be set
> > if the admin plugin is loaded (#53429)
>
> 0.8.2:
> > * removed the "admin" plugin from the list of plugins loaded by default
>
>
>
> I therefore would check the version of mysql-proxy and would
> vary the output of the meta data accordingly, e.g. (pseudocode)
>
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> ocf_version_cmp "$version" "0.8.1"
> ret=$?
>
> if [ $ret -eq 1 ]; then
> required=1
> else
> required=0
> fi
>
> ..
> echo <parameter name="admin_username" unique="0" required="$required">
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
> Would you consider this a proper way of handling such requirements
> or should i simply set required="0" and handle the special
> cases via some validate_all() method?

Right now, the RA says:

<parameter name="admin_username" unique="0" required="0">

I'd say let's keep it as it is in the meta-data and use validate
to let the user know if the configuration can work or not.
Sometimes meta-data won't fit all (unlike some caps) :-) And who
knows what 0.8.3 brings.

Thanks,

Dejan

> Thanks,
> Raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
> Barawitzkagasse 10/2/2/11 email. office@ipax.at
> 1190 Wien tel. +43 1 3670030
> FN 277995t HG Wien fax. +43 1 3670030 15
> ____________________________________________________________________
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: different meta data for different mysql-proxy versions [ In reply to ]

r.bhatia at ipax

May 15, 2012, 3:25 AM

Post #3 of 3 (1238 views)

Permalink

On 2012-05-14 17:21, Dejan Muhamedagic wrote:
> Right now, the RA says:
>
> <parameter name="admin_username" unique="0" required="0">
>
> I'd say let's keep it as it is in the meta-data and use validate
> to let the user know if the configuration can work or not.
> Sometimes meta-data won't fit all (unlike some caps):-) And who
> knows what 0.8.3 brings.

Thank you for your input. I did as you suggested.
Raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/