Mailing List Archive

On Mon, Feb 27, 2012 at 08:55:25PM +0800, Gao,Yan wrote:
> Hi,
> This one is also from the effort of SGI and Xinwei Hu.
>
> https://github.com/gao-yan/resource-agents/commit/7ae7560bb6e85f4870a1f1a2ed9c0fb2f6241c90

${x//,/ } is "bad substitution" in dash ...

Please check for bashisms, or switch to #!/bin/bash.

Other than that: :-)

Cheers,

--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

On 02/27/12 22:11, Lars Ellenberg wrote:
> On Mon, Feb 27, 2012 at 08:55:25PM +0800, Gao,Yan wrote:
>> Hi,
>> This one is also from the effort of SGI and Xinwei Hu.
>>
>> https://github.com/gao-yan/resource-agents/commit/7ae7560bb6e85f4870a1f1a2ed9c0fb2f6241c90
>
> ${x//,/ } is "bad substitution" in dash ...
>
> Please check for bashisms, or switch to #!/bin/bash.
>
> Other than that: :-)
:-) Thanks for pointing that out. Fixed:

https://github.com/gao-yan/resource-agents/commit/b7277ceaf17f6ed07fa67b6da140a46af96437ef

Regards,
Gao,Yan
--
Gao,Yan <ygao@suse.com>
Software Engineer
China Server Team, SUSE.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

On Wed, Feb 29, 2012 at 02:21:36PM +0800, Yan Gao wrote:
> On 02/27/12 22:11, Lars Ellenberg wrote:
> > On Mon, Feb 27, 2012 at 08:55:25PM +0800, Gao,Yan wrote:
> >> Hi,
> >> This one is also from the effort of SGI and Xinwei Hu.
> >>
> >> https://github.com/gao-yan/resource-agents/commit/7ae7560bb6e85f4870a1f1a2ed9c0fb2f6241c90
> >
> > ${x//,/ } is "bad substitution" in dash ...
> >
> > Please check for bashisms, or switch to #!/bin/bash.
> >
> > Other than that: :-)
> :-) Thanks for pointing that out. Fixed:
>
> https://github.com/gao-yan/resource-agents/commit/b7277ceaf17f6ed07fa67b6da140a46af96437ef

Merged.

Cheers,

Dejan

> Regards,
> Gao,Yan
> --
> Gao,Yan <ygao@suse.com>
> Software Engineer
> China Server Team, SUSE.
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/