Mailing List Archive: STONITH plugin vcenter, please check for regression

To fix unfullfillable rpm dependencies on the toolkit/sdk,
I recently pushed http://hg.linux-ha.org/glue/rev/508dd314f129
(also inline below; - use, + eval { require })

Anyone actually using this agent, please check and confirm
if that change breaks anything, or if it still works as intended.

Thanks,

# HG changeset patch
# User Lars Ellenberg <lars@linbit.com>
# Date 1316533223 -7200
# Node ID 508dd314f1291bdbd0e01d17b2c487820a79093b
# Parent 45b21f952b0fcf5f7ce2d490dd20a01a9ddc194c
Medium: fix stonith/external/vcenter to eval { require VMware::VIRuntime }

This should log a better error message, and as a side-effect, should cause
find-requires resp. perl.req to not RPM-require that module.

--- a/lib/plugins/stonith/external/vcenter
+++ b/lib/plugins/stonith/external/vcenter
@@ -114,7 +114,8 @@ Allowed values: 0, 1
# Command belongs to the group of commands that require connecting to VMware vCenter
elsif ($command ~~ @netCommands) {

- use VMware::VIRuntime;
+ eval { require VMware::VIRuntime; }
+ or dielog("Missing perl module VMware::VIRuntime. Download and install 'VMware Infrastructure (VI) Perl Toolkit', available at http://www.vmware.com/support/developer/viperltoolkit/ \n");

# A valid VI_CREDSTORE is required to avoid interactive prompt
( exists $ENV{'VI_CREDSTORE'} ) || dielog("VI_CREDSTORE not specified\n");

--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Hi Lars,

I've tested it in my environment and it seems that it works fine.
Best regards,

Nhan

On Tue, 2011-09-27 at 09:32 +0200, Lars Ellenberg wrote:
> To fix unfullfillable rpm dependencies on the toolkit/sdk,
> I recently pushed http://hg.linux-ha.org/glue/rev/508dd314f129
> (also inline below; - use, + eval { require })
>
> Anyone actually using this agent, please check and confirm
> if that change breaks anything, or if it still works as intended.
>
> Thanks,
>
>
> # HG changeset patch
> # User Lars Ellenberg <lars@linbit.com>
> # Date 1316533223 -7200
> # Node ID 508dd314f1291bdbd0e01d17b2c487820a79093b
> # Parent 45b21f952b0fcf5f7ce2d490dd20a01a9ddc194c
> Medium: fix stonith/external/vcenter to eval { require VMware::VIRuntime }
>
> This should log a better error message, and as a side-effect, should cause
> find-requires resp. perl.req to not RPM-require that module.
>
> --- a/lib/plugins/stonith/external/vcenter
> +++ b/lib/plugins/stonith/external/vcenter
> @@ -114,7 +114,8 @@ Allowed values: 0, 1
> # Command belongs to the group of commands that require connecting to VMware vCenter
> elsif ($command ~~ @netCommands) {
>
> - use VMware::VIRuntime;
> + eval { require VMware::VIRuntime; }
> + or dielog("Missing perl module VMware::VIRuntime. Download and install 'VMware Infrastructure (VI) Perl Toolkit', available at http://www.vmware.com/support/developer/viperltoolkit/ \n");
>
> # A valid VI_CREDSTORE is required to avoid interactive prompt
> ( exists $ENV{'VI_CREDSTORE'} ) || dielog("VI_CREDSTORE not specified\n");
>
>
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/