Mailing List Archive: fix implicit declaration in nv

fix implicit declaration in nv_backlight.

Feb 28, 2007, 9:36 AM

Post #1 of 4 (295 views)

drivers/video/nvidia/nv_backlight.c: In function 'nvidia_bl_init':
drivers/video/nvidia/nv_backlight.c:103: error: implicit declaration of function 'pmac_has_backlight_type'

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c~ 2007-02-20 22:25:15.000000000 -0500
+++ linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c 2007-02-20 22:25:31.000000000 -0500
@@ -12,6 +12,9 @@
#include <linux/backlight.h>
#include <linux/fb.h>
#include <linux/pci.h>
+#ifdef __powerpc__
+#include <asm/backlight.h>
+#endif
#include "nv_local.h"
#include "nv_type.h"
#include "nv_proto.h"

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: fix implicit declaration in nv_backlight. [ In reply to ]

linux-kernel at hansmi

Feb 28, 2007, 1:13 PM

Post #2 of 4 (271 views)

Permalink

On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> +#ifdef __powerpc__

Is __powerpc__ defined when cross compiling? I'd rather use
CONFIG_PMAC_BACKLIGHT instead of it.

Greets,
Michael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: fix implicit declaration in nv_backlight. [ In reply to ]

davej at redhat

Feb 28, 2007, 1:26 PM

Post #3 of 4 (269 views)

Permalink

On Wed, Feb 28, 2007 at 10:13:24PM +0100, Michael Hanselmann wrote:
> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> > +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.

Sounds ok to me.

Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: fix implicit declaration in nv_backlight. [ In reply to ]

adaplas at pol

Feb 28, 2007, 1:44 PM

Post #4 of 4 (265 views)

Permalink

> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
>> +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.

Agree with this too.

Tony

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/