Mailing List Archive: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer

[PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer

Sep 9, 2006, 8:37 AM

Post #1 of 4 (716 views)

From: Michael De Backer <micdb@skynet.be>

Configuration bits are not set properly for DMA on some chipset
revisions. It has already been corrected for M5229 (rev c7) but not for
M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
bus hangs).

Signed-off-by: Michael De Backer <micdb@skynet.be>
---
This has been tested on ASUS A8R32-MVP motherboard (M5229 c8) with
2.6.18-rc6, 2.6.18-rc6-mm1, 2.6.18-rc5-mm1, 2.6.17.10 and two different
cd-writers. It completely solves the problem.

The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:

--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1

if(m5229_revision <= 0x20)
tmpbyte = (tmpbyte & (~0x02)) | 0x01;
- else if (m5229_revision == 0xc7)
+ else if (m5229_revision == 0xc7 || 0xc8)
tmpbyte |= 0x03;
else
tmpbyte |= 0x01;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer [ In reply to ]

alan at lxorguk

Sep 9, 2006, 9:15 AM

Post #2 of 4 (672 views)

Permalink

Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:
> - else if (m5229_revision == 0xc7)
> + else if (m5229_revision == 0xc7 || 0xc8)

I don't think that is what you mean..

NAK

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer [ In reply to ]

micdb at skynet

Sep 9, 2006, 12:12 PM

Post #3 of 4 (672 views)

Permalink

Le samedi 09 septembre 2006 Ã 17:15 +0100, Alan Cox a Ã©crit :
> Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:
> > - else if (m5229_revision == 0xc7)
> > + else if (m5229_revision == 0xc7 || 0xc8)
>
> I don't think that is what you mean..
>
> NAK
Indeed, let's try again (please forgive my dumbness).

Configuration bits are not set properly for DMA on some chipset
revisions. It has already been corrected for M5229 (rev c7) but not for
M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
bus hangs).

Signed-off-by: Michael De Backer <micdb@skynet.be>
---
The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:

--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1

if(m5229_revision <= 0x20)
tmpbyte = (tmpbyte & (~0x02)) | 0x01;
- else if (m5229_revision == 0xc7)
+ else if (m5229_revision == 0xc7 || m5229_revision == 0xc8)
tmpbyte |= 0x03;
else
tmpbyte |= 0x01;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer [ In reply to ]

alan at lxorguk

Sep 9, 2006, 5:35 PM

Post #4 of 4 (678 views)

Permalink

Ar Sad, 2006-09-09 am 21:12 +0200, ysgrifennodd Michael De Backer:
> > I don't think that is what you mean..
> >
> > NAK
> Indeed, let's try again (please forgive my dumbness).

I've just put at least a dumb a mistake in 2.6.18 final so I wouldnt
worry - we all do it.

> Configuration bits are not set properly for DMA on some chipset
> revisions. It has already been corrected for M5229 (rev c7) but not for
> M5229 (rev c8). This leads to the bug described at
> http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
> bus hangs).
>
> Signed-off-by: Michael De Backer <micdb@skynet.be>

Acked-by: Alan Cox <alan@redhat.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/