Mailing List Archive: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error

2.6.17-rc1-mm1: drivers/acpi/numa.c compile error

Apr 7, 2006, 5:27 AM

Post #1 of 4 (413 views)

I'm getting the following compile error with CONFIG_ACPI_NUMA=y:

<-- snip -->

...
CC drivers/acpi/numa.o
drivers/acpi/numa.c: In function 'acpi_numa_init':
drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function)
drivers/acpi/numa.c:231: error: (Each undeclared identifier is reported only once
drivers/acpi/numa.c:231: error: for each function it appears in.)
make[2]: *** [drivers/acpi/numa.o] Error 1

<-- snip -->

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error [ In reply to ]

akpm at osdl

Apr 7, 2006, 1:59 PM

Post #2 of 4 (405 views)

Permalink

Adrian Bunk <bunk@stusta.de> wrote:
>
> I'm getting the following compile error with CONFIG_ACPI_NUMA=y:
>
> <-- snip -->
>
> ...
> CC drivers/acpi/numa.o
> drivers/acpi/numa.c: In function 'acpi_numa_init':
> drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function)

I'm not quite sure how we managed that, but I guess
unify-pxm_to_node-and-node_to_pxm.patch triggered it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error [ In reply to ]

bunk at stusta

Apr 9, 2006, 8:44 AM

Post #3 of 4 (404 views)

Permalink

On Fri, Apr 07, 2006 at 01:59:37PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > I'm getting the following compile error with CONFIG_ACPI_NUMA=y:
> >
> > <-- snip -->
> >
> > ...
> > CC drivers/acpi/numa.o
> > drivers/acpi/numa.c: In function 'acpi_numa_init':
> > drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function)
>
> I'm not quite sure how we managed that, but I guess
> unify-pxm_to_node-and-node_to_pxm.patch triggered it?

Yes, obviously (I got this error on i386):

config ACPI_NUMA
bool "NUMA support"
depends on NUMA
- depends on (IA64 || X86_64)
+ depends on (X86_32 || IA64 || X86_64)
default y if IA64_GENERIC || IA64_SGI_SN2

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error [ In reply to ]

rdunlap at xenotime

Apr 9, 2006, 8:57 AM

Post #4 of 4 (406 views)

Permalink

On Sun, 9 Apr 2006 17:44:46 +0200 Adrian Bunk wrote:

> On Fri, Apr 07, 2006 at 01:59:37PM -0700, Andrew Morton wrote:
> > Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > I'm getting the following compile error with CONFIG_ACPI_NUMA=y:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > CC drivers/acpi/numa.o
> > > drivers/acpi/numa.c: In function 'acpi_numa_init':
> > > drivers/acpi/numa.c:231: error: 'NR_NODE_MEMBLKS' undeclared (first use in this function)
> >
> > I'm not quite sure how we managed that, but I guess
> > unify-pxm_to_node-and-node_to_pxm.patch triggered it?
>
> Yes, obviously (I got this error on i386):
>
> config ACPI_NUMA
> bool "NUMA support"
> depends on NUMA
> - depends on (IA64 || X86_64)
> + depends on (X86_32 || IA64 || X86_64)
> default y if IA64_GENERIC || IA64_SGI_SN2

The new/fixed line should just be
depends on X86 || IA64
since X86_32 and X86_64 both set X86.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/