Mailing List Archive: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

[PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

Apr 24, 2024, 12:18 PM

Post #1 of 4 (10 views)

From: Konstantin Pugin <ria.freelander@gmail.com>

EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
It will be handled by same driver, so, it makes sense to add DT
definition for these block into driver's documentation.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
---
Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..c4bedf23368b 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -12,6 +12,7 @@ maintainers:
properties:
compatible:
enum:
+ - exar,xr20m1172
- nxp,sc16is740
- nxp,sc16is741
- nxp,sc16is750
--
2.44.0

Re: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART [ In reply to ]

andy.shevchenko at gmail

Apr 24, 2024, 12:34 PM

Post #2 of 4 (10 views)

Permalink

On Wed, Apr 24, 2024 at 10:19?PM Konstantin Pugin <rilian.la.te@ya.ru> wrote:
>
> From: Konstantin Pugin <ria.freelander@gmail.com>
>
> EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
> It will be handled by same driver, so, it makes sense to add DT
> definition for these block into driver's documentation.

blocks

..

> Reviewed-by: Andy Shevchenko <andy@kernel.org>

Hmm... Did I? IIRC I only reviewed patches 1 and 3. Am I mistaken?

--
With Best Regards,
Andy Shevchenko

Re: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART [ In reply to ]

ria.freelander at gmail

Apr 25, 2024, 12:25 AM

Post #3 of 4 (10 views)

Permalink

On Wed, Apr 24, 2024 at 10:34?PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Apr 24, 2024 at 10:19?PM Konstantin Pugin <rilian.la.te@ya.ru> wrote:
> >
> > From: Konstantin Pugin <ria.freelander@gmail.com>
> >
> > EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
> > It will be handled by same driver, so, it makes sense to add DT
> > definition for these block into driver's documentation.
>
> blocks
>
> ...
>
> > Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
> Hmm... Did I? IIRC I only reviewed patches 1 and 3. Am I mistaken?

I think it is my mistake, not yours. If you want, I can do a new
version without a tag.

> --
> With Best Regards,
> Andy Shevchenko

Re: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART [ In reply to ]

andy.shevchenko at gmail

Apr 25, 2024, 2:11 AM

Post #4 of 4 (10 views)

Permalink

On Thu, Apr 25, 2024 at 10:25:41AM +0300, Konstantin P. wrote:
> On Wed, Apr 24, 2024 at 10:34?PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Apr 24, 2024 at 10:19?PM Konstantin Pugin <rilian.la.te@ya.ru> wrote:
> > >
> > > From: Konstantin Pugin <ria.freelander@gmail.com>
> > >
> > > EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
> > > It will be handled by same driver, so, it makes sense to add DT
> > > definition for these block into driver's documentation.
> >
> > blocks

..

> > > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> >
> > Hmm... Did I? IIRC I only reviewed patches 1 and 3. Am I mistaken?
>
> I think it is my mistake, not yours. If you want, I can do a new
> version without a tag.

Yes, but give a chance to others to have a look at the code and the rest.

--
With Best Regards,
Andy Shevchenko