Mailing List Archive: [PATCH] watchdog: da9063: Add hard dependency on I2C

[PATCH] watchdog: da9063: Add hard dependency on I2C

Nov 29, 2021, 8:15 AM

Post #1 of 3 (52 views)

Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
reset handler") implements atomic save i2c transfer which uses i2c
functions directly. Add I2C hard dependency which overrides COMPILE_TEST.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 9d222ba17ec6..3207085f799f 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -207,6 +207,7 @@ config DA9055_WATCHDOG
config DA9063_WATCHDOG
tristate "Dialog DA9063 Watchdog"
depends on MFD_DA9063 || COMPILE_TEST
+ depends on I2C
select WATCHDOG_CORE
help
Support for the watchdog in the DA9063 PMIC.
--
2.25.1

Re: [PATCH] watchdog: da9063: Add hard dependency on I2C [ In reply to ]

linux at roeck-us

Nov 29, 2021, 12:15 PM

Post #2 of 3 (52 views)

Permalink

On 11/29/21 5:49 AM, Andrej Picej wrote:
> Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
> reset handler") implements atomic save i2c transfer which uses i2c
> functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9d222ba17ec6..3207085f799f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -207,6 +207,7 @@ config DA9055_WATCHDOG
> config DA9063_WATCHDOG
> tristate "Dialog DA9063 Watchdog"
> depends on MFD_DA9063 || COMPILE_TEST
> + depends on I2C
> select WATCHDOG_CORE
> help
> Support for the watchdog in the DA9063 PMIC.
>

Re: [PATCH] watchdog: da9063: Add hard dependency on I2C [ In reply to ]

linux at roeck-us

Nov 29, 2021, 2:15 PM

Post #3 of 3 (52 views)

Permalink

On Mon, Nov 29, 2021 at 02:49:38PM +0100, Andrej Picej wrote:
> Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
> reset handler") implements atomic save i2c transfer which uses i2c
> functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9d222ba17ec6..3207085f799f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -207,6 +207,7 @@ config DA9055_WATCHDOG
> config DA9063_WATCHDOG
> tristate "Dialog DA9063 Watchdog"
> depends on MFD_DA9063 || COMPILE_TEST
> + depends on I2C
> select WATCHDOG_CORE
> help
> Support for the watchdog in the DA9063 PMIC.
> --
> 2.25.1
>