Mailing List Archive

[PATCH v2 0/4] gpio: mvebu: Add PWM fan support
Hi everyone

This patch series was originally submitted by Andrew Lunn but got stalled.
I picked up the series and addressed what was discussed for the earlier
submission with some helpful input from Andrew. Hopefully this time support
for the PWM fan as found on Linksys WRT1900AC (Mamba) will make it in.

Implementing as an MFD was discarded due to backward compatibility. The
original discussion can be read at [1].

This series depends on two cleanup series. The first [2] ("gpio: mvebu:
preparatory cleanup for pwm-fan support") got applied but has yet to appear
in linux-next. The second one [3] ("gpio: mvebu: use BIT macro instead of
bit shifting") is still pending review.

[1] https://patchwork.ozlabs.org/patch/427287/
[2] https://lkml.org/lkml/2017/3/16/62
[3] https://lkml.org/lkml/2017/3/17/493

---

Changes v1 -> v2:
Patch 1/4 gpio: mvebu: Add limited PWM support:
* use BIT macro (suggested by Linus Walleij)
* move id from struct mvebu_pwm to struct mvebu_gpio_chip, implement
blink select as if else and comment on the chip id for code clarity
(to accommodate Linus Walleijs request for a code clarification /
comment. If you can word it better I'm all ears.)
* Move function comment mvebu_pwm_probe into the function itself.

---

Pending:
* Needs ACK from Thierry Reding to be merged via linux-gpio tree by Linus
Walleij.

---

Andrew Lunn (4):
gpio: mvebu: Add limited PWM support
mvebu: xp: Add pwm properties to .dtsi files
ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig
mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan

.../devicetree/bindings/gpio/gpio-mvebu.txt | 31 +++
MAINTAINERS | 2 +
arch/arm/boot/dts/armada-370.dtsi | 10 +-
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 8 +-
arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 +-
arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 +-
arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 +-
arch/arm/configs/mvebu_v7_defconfig | 2 +
drivers/gpio/gpio-mvebu.c | 291 +++++++++++++++++++--
9 files changed, 342 insertions(+), 30 deletions(-)

--
2.10.2
Re: [PATCH v2 0/4] gpio: mvebu: Add PWM fan support [ In reply to ]
On Sat, Mar 18, 2017 at 4:43 PM, Ralph Sennhauser
<ralph.sennhauser@gmail.com> wrote:

> This patch series was originally submitted by Andrew Lunn but got stalled.
> I picked up the series and addressed what was discussed for the earlier
> submission with some helpful input from Andrew. Hopefully this time support
> for the PWM fan as found on Linksys WRT1900AC (Mamba) will make it in.

All looks good to me, I'm waiting for an ACK from the PWM
maintainer.

Yours,
Linus Walleij
Re: [PATCH v2 0/4] gpio: mvebu: Add PWM fan support [ In reply to ]
On Thu, 23 Mar 2017 10:23:47 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Sat, Mar 18, 2017 at 4:43 PM, Ralph Sennhauser
> <ralph.sennhauser@gmail.com> wrote:
>
> > This patch series was originally submitted by Andrew Lunn but got
> > stalled. I picked up the series and addressed what was discussed
> > for the earlier submission with some helpful input from Andrew.
> > Hopefully this time support for the PWM fan as found on Linksys
> > WRT1900AC (Mamba) will make it in.
>
> All looks good to me, I'm waiting for an ACK from the PWM
> maintainer.
>
> Yours,
> Linus Walleij

Hi Linus,

There are still several open issues brought up by the PWM maintainer
after posting v2 which need to be addressed first (not done in 5
minutes). There will be a v3 for sure and maybe a v4 if necessary. v3
is currently under verification.

Thanks for applying the additional cleanup patch.

Thanks
Ralph