Mailing List Archive

Igor,

The proper fix is here:

https://patchwork.kernel.org/patch/376612/

So, NAK on your particular patch.

Mauro,

I do not see the above patch at linux next. And I couldn't find it in your kernel.org tree. What is its status?

This fixes a regression that is known to break cx23885 hardware initialization and can break ivtv hardware initialization.

Regards,
Andy

"Igor M. Liplianin" <liplianin@me.by> wrote:

>On my system, cx23885 based card reports default volume value above 70000.
>So, register cx25840 subdev fails. Although, the card don't have a/v inputs
>it needs a/v firmware to be loaded.
>
>Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
>---
> drivers/media/video/cx25840/cx25840-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
>index dfb198d..dc0cec7 100644
>--- a/drivers/media/video/cx25840/cx25840-core.c
>+++ b/drivers/media/video/cx25840/cx25840-core.c
>@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
> if (!is_cx2583x(state)) {
> default_volume = 228 - cx25840_read(client, 0x8d4);
> default_volume = ((default_volume / 2) + 23) << 9;
>+ if (default_volume > 65535)
>+ default_volume = 65535;
>
> state->volume = v4l2_ctrl_new_std(&state->hdl,
> &cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
>--
>1.7.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel