Mailing List Archive

It's hard to spot the missing define in your patch, which includes a
complete list of files of a whole package. Most of the material is
consumed by the Changelog, tl;dr.

Do you mean these two?

+#include <limits.h>

+/* match gnu to posix */
+#define MAXNAMLEN NAME_MAX

I would suggest to attach the responsible patch of the missing define only
and the necessary diff of a given ebuild file. That two files could be
enough, I guess.

The same suggestions goes for the previous offer.

BR: Dw.
--
dr Tóth Attila, Radiológus, 06-20-825-8057
Attila Toth MD, Radiologist, +36-20-825-8057

2014.November 14.(P) 21:43 időpontban daggs ezt írta:
> Greetings,
>
> I'd like to offer the following patch that fixes compilation errors of
> sys-process/cronie on gentoo+musl by defining a missing definition.
>
> Signed-off By: daggs@gmx.com

On 14 Nov 2014 at 22:05, "Tóth Attila" wrote:

> I would suggest to attach the responsible patch of the missing define only
> and the necessary diff of a given ebuild file. That two files could be
> enough, I guess.

yes and probably choose a better list and/or open a bugzilla entry as i doubt
this is hardened related at all ;).

Greetings,

> Sent: Friday, November 14, 2014 at 11:05 PM
> From: "Tóth Attila" <atoth@atoth.sote.hu>
> To: gentoo-hardened@lists.gentoo.org
> Subject: Re: [gentoo-hardened] [PATCH] fix sys-process/cronie compilation under gentoo+musl
>
> It's hard to spot the missing define in your patch, which includes a
> complete list of files of a whole package. Most of the material is
> consumed by the Changelog, tl;dr.
>
> Do you mean these two?
>
> +#include <limits.h>
>
> +/* match gnu to posix */
> +#define MAXNAMLEN NAME_MAX
>
> I would suggest to attach the responsible patch of the missing define only
> and the necessary diff of a given ebuild file. That two files could be
> enough, I guess.
>
> The same suggestions goes for the previous offer.
>
so the right way to do this is to add the fix patch, a patch that modifies an existing ebuild and if the ebuild is not present in the musl branch I should mentioned that?

Greetings,

> Sent: Friday, November 14, 2014 at 11:52 PM
> From: "PaX Team" <pageexec@freemail.hu>
> To: gentoo-hardened@lists.gentoo.org
> Subject: Re: [gentoo-hardened] [PATCH] fix sys-process/cronie compilation under gentoo+musl
>
> On 14 Nov 2014 at 22:05, "Tóth Attila" wrote:
>
> > I would suggest to attach the responsible patch of the missing define only
> > and the necessary diff of a given ebuild file. That two files could be
> > enough, I guess.
>
> yes and probably choose a better list and/or open a bugzilla entry as i doubt
> this is hardened related at all ;).
>
>
>
not sure I understand the latter, this is a issue that is caused by running gentoo atop of musl, according to this wiki page, https://wiki.gentoo.org/wiki/Project:Hardened_musl I should send the patches to this list.

am I wrong?

Musl is ment to be an alternative to libc. Some of the hardened folks
(perverts ;->) are interested to make it work on Hardened Gentoo. But musl
itself is not necessary hardened per se. You've linked the Hardened
project subpage. The package maintainer happens to be a hardened developer
(blueness). So your message probably reaches him. But it's not the optimal
channel. So what pageexec tried to advise, is to open a bug in the gentoo
bug tracking system and attach your patches and diffs to the bug. But I
still suggest to attach a single diff per file. And don't try to use diff
as a version control system. Specify sys-libs/musl in the title and the
description and it will reach the maintainer of the package, will probably
got assigned to him.

https://bugs.gentoo.org

Regards:
Dw.
--
dr Tóth Attila, Radiológus, 06-20-825-8057
Attila Toth MD, Radiologist, +36-20-825-8057

2014.November 15.(Szo) 06:25 időpontban daggs ezt írta:
> Greetings,
>
>> Sent: Friday, November 14, 2014 at 11:52 PM
>> From: "PaX Team" <pageexec@freemail.hu>
>> To: gentoo-hardened@lists.gentoo.org
>> Subject: Re: [gentoo-hardened] [PATCH] fix sys-process/cronie
>> compilation under gentoo+musl
>>
>> On 14 Nov 2014 at 22:05, "Tóth Attila" wrote:
>>
>> > I would suggest to attach the responsible patch of the missing define
>> only
>> > and the necessary diff of a given ebuild file. That two files could be
>> > enough, I guess.
>>
>> yes and probably choose a better list and/or open a bugzilla entry as i
>> doubt
>> this is hardened related at all ;).
>>
>>
>>
> not sure I understand the latter, this is a issue that is caused by
> running gentoo atop of musl, according to this wiki page,
> https://wiki.gentoo.org/wiki/Project:Hardened_musl I should send the
> patches to this list.
>
> am I wrong?
>
>

understood, better yet, I'll ask blueness probably how does he wants the patches.

thanks for the explanation.

> Sent: Saturday, November 15, 2014 at 9:33 AM
> From: "Tóth Attila" <atoth@atoth.sote.hu>
> To: gentoo-hardened@lists.gentoo.org
> Subject: Re: [gentoo-hardened] [PATCH] fix sys-process/cronie compilation under gentoo+musl
>
> Musl is ment to be an alternative to libc. Some of the hardened folks
> (perverts ;->) are interested to make it work on Hardened Gentoo. But musl
> itself is not necessary hardened per se. You've linked the Hardened
> project subpage. The package maintainer happens to be a hardened developer
> (blueness). So your message probably reaches him. But it's not the optimal
> channel. So what pageexec tried to advise, is to open a bug in the gentoo
> bug tracking system and attach your patches and diffs to the bug. But I
> still suggest to attach a single diff per file. And don't try to use diff
> as a version control system. Specify sys-libs/musl in the title and the
> description and it will reach the maintainer of the package, will probably
> got assigned to him.
>
> https://bugs.gentoo.org
>
> Regards:
> Dw.
> --
> dr Tóth Attila, Radiológus, 06-20-825-8057
> Attila Toth MD, Radiologist, +36-20-825-8057
>
> 2014.November 15.(Szo) 06:25 időpontban daggs ezt írta:
> > Greetings,
> >
> >> Sent: Friday, November 14, 2014 at 11:52 PM
> >> From: "PaX Team" <pageexec@freemail.hu>
> >> To: gentoo-hardened@lists.gentoo.org
> >> Subject: Re: [gentoo-hardened] [PATCH] fix sys-process/cronie
> >> compilation under gentoo+musl
> >>
> >> On 14 Nov 2014 at 22:05, "Tóth Attila" wrote:
> >>
> >> > I would suggest to attach the responsible patch of the missing define
> >> only
> >> > and the necessary diff of a given ebuild file. That two files could be
> >> > enough, I guess.
> >>
> >> yes and probably choose a better list and/or open a bugzilla entry as i
> >> doubt
> >> this is hardened related at all ;).
> >>
> >>
> >>
> > not sure I understand the latter, this is a issue that is caused by
> > running gentoo atop of musl, according to this wiki page,
> > https://wiki.gentoo.org/wiki/Project:Hardened_musl I should send the
> > patches to this list.
> >
> > am I wrong?
> >
> >
>
>
>
>

On 11/14/14 16:52, PaX Team wrote:
> On 14 Nov 2014 at 22:05, "Tóth Attila" wrote:
>
>> I would suggest to attach the responsible patch of the missing define only
>> and the necessary diff of a given ebuild file. That two files could be
>> enough, I guess.
>
> yes and probably choose a better list and/or open a bugzilla entry as i doubt
> this is hardened related at all ;).
>

For stuff like this just open a bug and cc me. This isn't hardened
related but the musl project aims to bring hardening to musl in gentoo.
So, you're going to still have to deal with non-hardened musl issue.
Open a bug report is probably the way to go with those.


--
Anthony G. Basile, Ph. D.
Chair of Information Technology
D'Youville College
Buffalo, NY 14201
(716) 829-8197

> Sent: Saturday, November 15, 2014 at 3:47 PM
> From: "Anthony G. Basile" <basile@opensource.dyc.edu>
> To: gentoo-hardened@lists.gentoo.org
> Subject: Re: [gentoo-hardened] [PATCH] fix sys-process/cronie compilation under gentoo+musl
>
> On 11/14/14 16:52, PaX Team wrote:
> > On 14 Nov 2014 at 22:05, "Tóth Attila" wrote:
> >
> >> I would suggest to attach the responsible patch of the missing define only
> >> and the necessary diff of a given ebuild file. That two files could be
> >> enough, I guess.
> >
> > yes and probably choose a better list and/or open a bugzilla entry as i doubt
> > this is hardened related at all ;).
> >
>
> For stuff like this just open a bug and cc me. This isn't hardened
> related but the musl project aims to bring hardening to musl in gentoo.
> So, you're going to still have to deal with non-hardened musl issue.
> Open a bug report is probably the way to go with those.
>
>
> --
> Anthony G. Basile, Ph. D.
> Chair of Information Technology
> D'Youville College
> Buffalo, NY 14201
> (716) 829-8197
>
>

after talking to blueness, it was decided I'll open bugs and provide the patches there.