Mailing List Archive

Re: [gentoo-commits] gentoo-x86 commit in net-dialup/freeradius: freeradius-2.0.3.ebuild
On Sun, Apr 13, 2008 at 05:41:18PM +0000, Alin Nastac (mrness) wrote:
> mrness 08/04/13 17:41:18
>
> Modified: ChangeLog
> Added: freeradius-2.0.3.ebuild
> Log:
> Version bump.
> (Portage version: 2.1.4.4)

> src_install() {
> mv "${D}/usr/share/doc/${PN}" "${D}/usr/share/doc/${PF}"
> gzip -f -9 "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}
Doesn't this gzip command rather defeat the purpose of $PORTAGE_COMPRESS
and $PORTAGE_COMPRESS_FLAGS?

It seems this might work better:

ecompress "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}

This way a user can opt to use bzip2,lzma, or no compression at all.
> --
> gentoo-commits@lists.gentoo.org mailing list
>
Re: Re: [gentoo-commits] gentoo-x86 commit in net-dialup/freeradius: freeradius-2.0.3.ebuild [ In reply to ]
On Sunday 13 April 2008, Thomas Anderson wrote:
> On Sun, Apr 13, 2008 at 05:41:18PM +0000, Alin Nastac (mrness) wrote:
> > mrness 08/04/13 17:41:18
> >
> > Modified: ChangeLog
> > Added: freeradius-2.0.3.ebuild
> > Log:
> > Version bump.
> > (Portage version: 2.1.4.4)
> >
> > src_install() {
> > mv "${D}/usr/share/doc/${PN}" "${D}/usr/share/doc/${PF}"
> > gzip -f -9 "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}
>
> Doesn't this gzip command rather defeat the purpose of $PORTAGE_COMPRESS
> and $PORTAGE_COMPRESS_FLAGS?

it doesnt defeat it as ecompress will decompress things automatically. it
just makes the call pointless.

> It seems this might work better:
>
> ecompress "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}
>
> This way a user can opt to use bzip2,lzma, or no compression at all.

no need to call ecompress as we already have a function to do what is needed:
prepalldocs
-mike