Mailing List Archive

Re: [gentoo-commits] gentoo-x86 commit in www-servers/resin: ChangeLog resin-3.0.25.ebuild resin-3.1.4.ebuild
On 09:42 Fri 14 Dec , Krzysiek Pawlik (nelchael) wrote:
> 1.1 www-servers/resin/resin-3.1.4.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/www-servers/resin/resin-3.1.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/www-servers/resin/resin-3.1.4.ebuild?rev=1.1&content-type=text/plain

> src_unpack() {
>
> unpack ${A}
> for i in "${WORKDIR}"/${PV}/resin-${PV}-*; do
> epatch "${i}"
> done;

How about:

epatch "${WORKDIR}"/${PV}/resin-${PV}-*

> java-ant_bsfix_one "${S}/build.xml"
>
> sed -i -e 's/256m/384m/' "${S}/build.xml"
>
> }

> src_compile() {
>
> append-flags -fPIC -DPIC

Somehow it seems wrong to append this for a whole package...

> chmod 755 "${S}/configure"

fperms means you don't need S or quotes.

> src_install() {
>
> make DESTDIR="${D}" install || die

Does emake work? If not, please add a comment to that effect.

> einfo "Fixing permissions..."
> chown -R resin:resin "${D}${RESIN_HOME}"
> chown -R resin:resin "${D}/etc/resin"
> chown -R resin:resin "${D}/var/log/resin"
> chown -R resin:resin "${D}/var/lib/resin"
> chown -R resin:resin "${D}/var/run/resin"
>
> chmod 644 "${D}/etc/conf.d/resin"
> chmod 755 "${D}/etc/init.d/resin"
> chmod 750 "${D}/var/lib/resin"
> chmod 750 "${D}/var/run/resin"
> chmod 750 "${D}/etc/resin"

Again, fowners/fperms can make this a bit easier to read.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
Re: Re: [gentoo-commits] gentoo-x86 commit in www-servers/resin: ChangeLog resin-3.0.25.ebuild resin-3.1.4.ebuild [ In reply to ]
On Sunday 16 December 2007 08:03:37 Donnie Berkholz wrote:
> > chmod 755 "${S}/configure"
>
> fperms means you don't need S or quotes.

fperms works on D. Not S.

--
Bo Andresen
Re: Re: [gentoo-commits] gentoo-x86 commit in www-servers/resin: ChangeLog resin-3.0.25.ebuild resin-3.1.4.ebuild [ In reply to ]
On 12:40 Sun 16 Dec , Bo Ørsted Andresen wrote:
> On Sunday 16 December 2007 08:03:37 Donnie Berkholz wrote:
> > > chmod 755 "${S}/configure"
> >
> > fperms means you don't need S or quotes.
>
> fperms works on D. Not S.

Good point. It's worth noting that this was the only file in S, and the
others are all in D.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
Re: Re: [gentoo-commits] gentoo-x86 commit in www-servers/resin: ChangeLog resin-3.0.25.ebuild resin-3.1.4.ebuild [ In reply to ]
Donnie Berkholz wrote:
>> 1.1 www-servers/resin/resin-3.1.4.ebuild
>> src_unpack() {
>>
>> unpack ${A}
>> for i in "${WORKDIR}"/${PV}/resin-${PV}-*; do
>> epatch "${i}"
>> done;
>
> How about:
>
> epatch "${WORKDIR}"/${PV}/resin-${PV}-*

Leftover from tests, will be fixed with next bump.

>> src_compile() {
>>
>> append-flags -fPIC -DPIC
>
> Somehow it seems wrong to append this for a whole package...

It builds only one .so library - the rest is in Java, so I don't see a problem
with using append-flags.

>> src_install() {
>>
>> make DESTDIR="${D}" install || die
>
> Does emake work? If not, please add a comment to that effect.

Didn't test, but I will with next bump.

>> einfo "Fixing permissions..."
>> chown -R resin:resin "${D}${RESIN_HOME}"
>> chown -R resin:resin "${D}/etc/resin"
>> chown -R resin:resin "${D}/var/log/resin"
>> chown -R resin:resin "${D}/var/lib/resin"
>> chown -R resin:resin "${D}/var/run/resin"
>>
>> chmod 644 "${D}/etc/conf.d/resin"
>> chmod 755 "${D}/etc/init.d/resin"
>> chmod 750 "${D}/var/lib/resin"
>> chmod 750 "${D}/var/run/resin"
>> chmod 750 "${D}/etc/resin"
>
> Again, fowners/fperms can make this a bit easier to read.

I'll fix it with next bump.

--
Krzysiek Pawlik <nelchael at gentoo.org> key id: 0xBC555551
desktop-misc, java, apache, ppc, vim, kernel...