Mailing List Archive

On 02:38 Tue 02 Oct , Saleem Abdulrasool (compnerd) wrote:
> 1.1 app-misc/tracker/tracker-0.6.3.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/tracker/tracker-0.6.3.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/tracker/tracker-0.6.3.ebuild?rev=1.1&content-type=text/plain

> function notify_inotify() {

Odd to declare a couple functions with 'function' then not do it for the
rest. Was this copied and pasted?

> pkg_setup() {
> linux-info_pkg_setup
>
> if built_with_use 'dev-db/sqlite' 'nothreadsafe' ; then
> eerror "You must build sqlite with threading support"
> die "dev-db/sqlite built with nothreadsafe"

No need for the single quotes in the built_with_use() params, and you
could use a local variable for the message so you don't repeat roughly
the same thing twice.

> cd ${S}
>
> epatch ${FILESDIR}/${PN}-0.6.3-fix-unac-option.patch

> make DESTDIR="${D}" install || die "install failed"

Quoting and emake

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list