Mailing List Archive

On 20:21 Mon 24 Sep , Mart Raudsepp (leio) wrote:
> leio 07/09/24 20:21:42
>
> Modified: ChangeLog
> Added: gtk+-2.12.0-r1.ebuild
> Log:
> Hopefully fix netscape-flash crashes and infinite loops and Java SWT tooltips weird behaviour and related crashes. Bug #193513 and part of bug #192310 and self-observation
> (Portage version: 2.1.3.9)

Numerous quoting issues for D and S

> 1.1 x11-libs/gtk+/gtk+-2.12.0-r1.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-libs/gtk+/gtk+-2.12.0-r1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-libs/gtk+/gtk+-2.12.0-r1.ebuild?rev=1.1&content-type=text/plain

> pkg_setup() {
> if ! built_with_use x11-libs/cairo X; then
> einfo "Please re-emerge x11-libs/cairo with the X USE flag set"
> die "cairo needs the X flag set"
> fi
> }

One trick I like doing here is setting a local variable, then using it
twice to avoid duplicating the same info. For example:

local msg="Please re-emerge x11-libs/cairo with the X USE flag set"
eerror "$msg"
die "$msg"

BTW, note that I changed that einfo to an eerror, since it's dying.

> if [ -e /usr/lib/gtk-2.0/2.[^1]* ]; then
> elog "You need to rebuild ebuilds that installed into" /usr/lib/gtk-2.0/2.[^1]*
> elog "to do that you can use qfile from portage-utils:"
> elog "emerge -va1 \$(qfile -qC /usr/lib/gtk-2.0/2.[^1]*)"

Looks like get_libdir() should be here.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list