Mailing List Archive

On Monday 24 September 2007 21:53:14 Donnie Berkholz wrote:
> > - use video_cards_mga || myconf="${myconf} --disable-mga"
> > - ( use X && use video_cards_mga ) || myconf="${myconf} --disable-xmga"
> > + use video_cards_mga && myconf="${myconf} --enable-mga"
> > + ( use X && use video_cards_mga ) && myconf="${myconf} --enable-xmga"
>
> Subshells are gross, can you try a code block { } instead?

A code block isn't even required since this grouping does the same as without
it. More importantly, though, why isn't this ebuild using use_enable? It
seems that:

use X && myconf="$myconf $(use_enable video_cards_mga xmga)"
myconf="$myconf $(use_enable video_cards_mga mga)"

would do the same?

In another example from the ebuild:

> use bl && myconf="${myconf} --enable-bl"

if USE=bl is disabled --disable-bl isn't passed to the configure script which
means the default is picked. There's a good chance that this kind of
behaviour results in automagic deps...

http://www.gentoo.org/proj/en/qa/automagic.xml

--
Bo Andresen