Mailing List Archive: Re: [gentoo-commits] gentoo-x86 commit in media-gfx/splashutils: ChangeLog splashutils-1.5.2.1.ebuild

On 11:48 Sun 23 Sep , Michael Januszewski (spock) wrote:
> spock 07/09/23 11:48:45
>
> Modified: ChangeLog
> Added: splashutils-1.5.2.1.ebuild
> Log:
> Version bump (bugfix release).
> (Portage version: 2.1.3.9)

> 1.1 media-gfx/splashutils/splashutils-1.5.2.1.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-gfx/splashutils/splashutils-1.5.2.1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-gfx/splashutils/splashutils-1.5.2.1.ebuild?rev=1.1&content-type=text/plain
> V_JPEG="6b"
> V_PNG="1.2.18"
> V_ZLIB="1.2.3"
> V_FT="2.3.5"
>
> ZLIBSRC="libs/zlib-${V_ZLIB}"
> LPNGSRC="libs/libpng-${V_PNG}"
> JPEGSRC="libs/jpeg-${V_JPEG}"
> FT2SRC="libs/freetype-${V_FT}"
>
> IUSE="hardened png truetype mng gpm"
>
> DESCRIPTION="Framebuffer splash utilities."
> HOMEPAGE="http://fbsplash.berlios.de"
> SRC_URI="mirror://berlios/fbsplash/${PN}-lite-${PV}.tar.bz2
> mirror://berlios/fbsplash/${GENTOOSPLASH}.tar.bz2
> mirror://gentoo/${MISCSPLASH}.tar.bz2
> mirror://sourceforge/libpng/libpng-${V_PNG}.tar.bz2
> ftp://ftp.uu.net/graphics/jpeg/jpegsrc.v${V_JPEG}.tar.gz
> mirror://sourceforge/freetype/freetype-${V_FT}.tar.bz2
> http://www.gzip.org/zlib/zlib-${V_ZLIB}.tar.bz2"

Is there some way to avoid using bundled libs here? It really turns into
a PITA for security issues etc.

> [ ! -d ${S}/libs ] && mkdir ${S}/libs
> [ ! -d ${S}/objs ] && mkdir ${S}/objs
> mv ${WORKDIR}/{libpng-${V_PNG},jpeg-${V_JPEG},zlib-${V_ZLIB},freetype-${V_FT}} ${S}/libs

> rm ${S}/libs/zlib-${V_ZLIB}/Makefile
>
> cd ${S}
> ln -sf ${S} ${WORKDIR}/core

> sed -e 's@K_CFLAGS =@K_CFLAGS = -fno-stack-protector@' -i ${S}/Makefile

> sed -i -e 's/fbtruetype kbd/kbd/' ${SM}/Makefile

> sed -i -e "s#/lib/splash#/$(get_libdir)/splash#" ${S}/scripts/{splash_manager,splash_geninitramfs}

> cd ${SM}

> cd ${S}

> cd ${SG}

> cd ${SM}
> make DESTDIR=${D} LIB=${LIB} install || die
>
> export ZLIBSRC LPNGSRC JPEGSRC FT2SRC
> cd ${S}
> make DESTDIR=${D} LIB=${LIB} install || die
>
> mv ${D}/usr/${LIB}/libfbsplash.so* ${D}/${LIB}/

> newinitd ${SG}/init-fbcondecor fbcondecor
> newconfd ${SG}/splash.conf splash
> newconfd ${SG}/fbcondecor.conf fbcondecor

> doins ${SG}/initrd.splash

> doins ${SM}/fbtruetype/luxisri.ttf

> cd ${SG}
> make DESTDIR=${D} LIB=${LIB} install || die "failed to install the splash plugin"
> else
> cp ${SG}/splash-functions-bl1.sh ${D}/sbin/splash-functions.sh
> fi
>
> sed -i -e "s#/lib/splash#/${LIB}/splash#" ${D}/sbin/splash-functions.sh

Lots of places here where quotes should be added around variables that
can contain spaces.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list

On Sun, Sep 23, 2007 at 02:29:55PM -0700, Donnie Berkholz wrote:

> > SRC_URI="mirror://berlios/fbsplash/${PN}-lite-${PV}.tar.bz2
> > mirror://berlios/fbsplash/${GENTOOSPLASH}.tar.bz2
> > mirror://gentoo/${MISCSPLASH}.tar.bz2
> > mirror://sourceforge/libpng/libpng-${V_PNG}.tar.bz2
> > ftp://ftp.uu.net/graphics/jpeg/jpegsrc.v${V_JPEG}.tar.gz
> > mirror://sourceforge/freetype/freetype-${V_FT}.tar.bz2
> > http://www.gzip.org/zlib/zlib-${V_ZLIB}.tar.bz2"
>
> Is there some way to avoid using bundled libs here? It really turns into
> a PITA for security issues etc.

Not that I know of. I need these libs to be compiled against klibc,
not glibc. AFAIK I just have to build them along with the rest of
fbcondecor_helper.

> > [..]
> > else
> > cp ${SG}/splash-functions-bl1.sh ${D}/sbin/splash-functions.sh
> > fi
> >
> > sed -i -e "s#/lib/splash#/${LIB}/splash#" ${D}/sbin/splash-functions.sh
>
> Lots of places here where quotes should be added around variables that
> can contain spaces.

Thanks, I've just submitted a change which should fix all of these in the
latest ebuild.

Best regards.
--
Michal Januszewski JID: spock@im.gentoo.org
Gentoo Linux Developer http://people.gentoo.org/spock

--
gentoo-dev@gentoo.org mailing list