Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Gentoo>
  3. Dev
[PATCH 7/8] profiles/use.desc: Make USE=egl global
mgorny at gentoo
Dec 17, 2023, 8:05 AM
Post #1 of 4 (80 views)
Permalink
Add a global USE=egl flag. It is used semi-consistently in 13 packages,
though some use it as "EGL only" flag (there is also one using
USE=egl-only).

Signed-off-by: Micha? Górny <mgorny@gentoo.org>
---
dev-games/openscenegraph-openmw/metadata.xml | 1 -
dev-games/openscenegraph/metadata.xml | 1 -
dev-qt/qtgui/metadata.xml | 1 -
media-libs/clutter/metadata.xml | 1 -
media-libs/gst-plugins-bad/metadata.xml | 1 -
media-libs/gst-plugins-base/metadata.xml | 1 -
media-libs/libepoxy/metadata.xml | 3 ---
media-libs/libva-compat/metadata.xml | 1 -
media-plugins/gst-plugins-gtk/metadata.xml | 1 -
media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
profiles/use.desc | 1 +
11 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/dev-games/openscenegraph-openmw/metadata.xml b/dev-games/openscenegraph-openmw/metadata.xml
index 26f01f3f105e..95b4405f0657 100644
--- a/dev-games/openscenegraph-openmw/metadata.xml
+++ b/dev-games/openscenegraph-openmw/metadata.xml
@@ -27,7 +27,6 @@
<use>
<flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
<flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
<flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
<flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
diff --git a/dev-games/openscenegraph/metadata.xml b/dev-games/openscenegraph/metadata.xml
index 88b68f751d28..049f3df3a410 100644
--- a/dev-games/openscenegraph/metadata.xml
+++ b/dev-games/openscenegraph/metadata.xml
@@ -15,7 +15,6 @@
<use>
<flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
<flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
<flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
<flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
diff --git a/dev-qt/qtgui/metadata.xml b/dev-qt/qtgui/metadata.xml
index ab06e044872c..55e237a8d1ef 100644
--- a/dev-qt/qtgui/metadata.xml
+++ b/dev-qt/qtgui/metadata.xml
@@ -6,7 +6,6 @@
<name>Gentoo Qt Project</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL integration</flag>
<flag name="eglfs">Build the EGL Full Screen/Single Surface platform plugin</flag>
<flag name="evdev">Enable support for input devices via evdev</flag>
<flag name="ibus">Build the IBus input method plugin</flag>
diff --git a/media-libs/clutter/metadata.xml b/media-libs/clutter/metadata.xml
index c945cf9a5946..bb66dfa52e7a 100644
--- a/media-libs/clutter/metadata.xml
+++ b/media-libs/clutter/metadata.xml
@@ -6,7 +6,6 @@
<name>Gentoo GNOME Desktop</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL backend.</flag>
<flag name="gtk">Use gdk-pixbuf from <pkg>x11-libs/gtk+</pkg> as image rendering backend</flag>
</use>
<upstream>
diff --git a/media-libs/gst-plugins-bad/metadata.xml b/media-libs/gst-plugins-bad/metadata.xml
index 477b2c0d2320..3b0ff434a203 100644
--- a/media-libs/gst-plugins-bad/metadata.xml
+++ b/media-libs/gst-plugins-bad/metadata.xml
@@ -7,7 +7,6 @@
</maintainer>
<use>
<flag name="bzip2">Enable bzip2 encoder/decoder plugin</flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="qsv">Enable Intel Quick Sync Video using the <pkg>media-libs/oneVPL</pkg> dispatcher</flag>
</use>
</pkgmetadata>
diff --git a/media-libs/gst-plugins-base/metadata.xml b/media-libs/gst-plugins-base/metadata.xml
index f540928582cf..179c5151b43c 100644
--- a/media-libs/gst-plugins-base/metadata.xml
+++ b/media-libs/gst-plugins-base/metadata.xml
@@ -7,7 +7,6 @@
</maintainer>
<use>
<flag name="gbm">Enable Graphics Buffer Manager based EGL windowing system support (requires egl and at least one of gles or opengl)</flag>
- <flag name="egl">Enable EGL platform support</flag>
<flag name="gles2">Enable OpenGL library and plugin via GLESv2 API (requires egl)</flag>
<flag name="ivorbis">Enable integer based vorbis decoder</flag>
<flag name="opengl">Enable OpenGL library and plugin via desktop OpenGL API</flag>
diff --git a/media-libs/libepoxy/metadata.xml b/media-libs/libepoxy/metadata.xml
index e092005ad115..509b7d255563 100644
--- a/media-libs/libepoxy/metadata.xml
+++ b/media-libs/libepoxy/metadata.xml
@@ -5,9 +5,6 @@
<email>x11@gentoo.org</email>
<name>X11</name>
</maintainer>
- <use>
- <flag name="egl">Enable EGL support.</flag>
- </use>
<upstream>
<remote-id type="github">anholt/libepoxy</remote-id>
</upstream>
diff --git a/media-libs/libva-compat/metadata.xml b/media-libs/libva-compat/metadata.xml
index e454a2831910..455cac07f59c 100644
--- a/media-libs/libva-compat/metadata.xml
+++ b/media-libs/libva-compat/metadata.xml
@@ -6,7 +6,6 @@
<name>James Le Cuirot</name>
</maintainer>
<use>
- <flag name="egl">Enables EGL support.</flag>
<flag name="drm">Enables VA/DRM API support.</flag>
</use>
<upstream>
diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-plugins/gst-plugins-gtk/metadata.xml
index 7235f1bab7ba..f3b18c11bcfc 100644
--- a/media-plugins/gst-plugins-gtk/metadata.xml
+++ b/media-plugins/gst-plugins-gtk/metadata.xml
@@ -6,7 +6,6 @@
<name>GStreamer package maintainers</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL platform usage</flag>
<flag name="gles2">Enable gtkglsink OpenGL sink based on GLESv2 API</flag>
<flag name="opengl">Enable gtkglsink OpenGL sink based on desktop OpenGL API</flag>
</use>
diff --git a/media-plugins/gst-plugins-vaapi/metadata.xml b/media-plugins/gst-plugins-vaapi/metadata.xml
index 3f726dfa99ea..6997730f1472 100644
--- a/media-plugins/gst-plugins-vaapi/metadata.xml
+++ b/media-plugins/gst-plugins-vaapi/metadata.xml
@@ -7,7 +7,6 @@
</maintainer>
<use>
<flag name="drm">Enable DRM renderer</flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="gles2">Enable GLESv2 and GLESv3 support</flag>
</use>
</pkgmetadata>
diff --git a/profiles/use.desc b/profiles/use.desc
index 62a640902f88..70a1dcced54a 100644
--- a/profiles/use.desc
+++ b/profiles/use.desc
@@ -72,6 +72,7 @@ dvb - Add support for DVB (Digital Video Broadcasting)
dvd - Add support for DVDs
dvdr - Add support for DVD writer hardware (e.g. in xcdroast)
eds - Enable support for Evolution-Data-Server (EDS)
+egl - Enable EGL support
elogind - Enable session tracking via sys-auth/elogind
emacs - Add support for GNU Emacs
emboss - Add support for the European Molecular Biology Open Software Suite
--
2.43.0
Re: [PATCH 7/8] profiles/use.desc: Make USE=egl global [ In reply to ]
leio at gentoo
Dec 19, 2023, 12:33 AM
Post #2 of 4 (78 views)
Permalink
Ühel kenal päeval, P, 17.12.2023 kell 17:05, kirjutas Micha? Górny:
> Add a global USE=egl flag.  It is used semi-consistently in 13
> packages,
> though some use it as "EGL only" flag (there is also one using
> USE=egl-only).
>
> Signed-off-by: Micha? Górny <mgorny@gentoo.org>
> ---
>  dev-games/openscenegraph-openmw/metadata.xml | 1 -
>  dev-games/openscenegraph/metadata.xml        | 1 -
>  dev-qt/qtgui/metadata.xml                    | 1 -
>  media-libs/clutter/metadata.xml              | 1 -
>  media-libs/gst-plugins-bad/metadata.xml      | 1 -
>  media-libs/gst-plugins-base/metadata.xml     | 1 -
>  media-libs/libepoxy/metadata.xml             | 3 ---
>  media-libs/libva-compat/metadata.xml         | 1 -
>  media-plugins/gst-plugins-gtk/metadata.xml   | 1 -
>  media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
>  profiles/use.desc                            | 1 +
>  11 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-
> plugins/gst-plugins-gtk/metadata.xml
> index 7235f1bab7ba..f3b18c11bcfc 100644
> --- a/media-plugins/gst-plugins-gtk/metadata.xml
> +++ b/media-plugins/gst-plugins-gtk/metadata.xml
> @@ -6,7 +6,6 @@
>         <name>GStreamer package maintainers</name>
>  </maintainer>
>  <use>
> -       <flag name="egl">Enable EGL platform usage</flag>
>         <flag name="gles2">Enable gtkglsink OpenGL sink based on
> GLESv2 API</flag>
>         <flag name="opengl">Enable gtkglsink OpenGL sink based on
> desktop OpenGL API</flag>
>  </use>

Please do not lose extra information provided in local descriptions in
this and many other cases where you remove the local description (in
other proposed global USE flag cases as well). Just don't remove the
local description then. Thanks.


Mart
Re: [PATCH 7/8] profiles/use.desc: Make USE=egl global [ In reply to ]
mgorny at gentoo
Dec 19, 2023, 3:50 AM
Post #3 of 4 (77 views)
Permalink
On Tue, 2023-12-19 at 10:33 +0200, Mart Raudsepp wrote:
> Ühel kenal päeval, P, 17.12.2023 kell 17:05, kirjutas Micha? Górny:
> > Add a global USE=egl flag.  It is used semi-consistently in 13
> > packages,
> > though some use it as "EGL only" flag (there is also one using
> > USE=egl-only).
> >
> > Signed-off-by: Micha? Górny <mgorny@gentoo.org>
> > ---
> >  dev-games/openscenegraph-openmw/metadata.xml | 1 -
> >  dev-games/openscenegraph/metadata.xml        | 1 -
> >  dev-qt/qtgui/metadata.xml                    | 1 -
> >  media-libs/clutter/metadata.xml              | 1 -
> >  media-libs/gst-plugins-bad/metadata.xml      | 1 -
> >  media-libs/gst-plugins-base/metadata.xml     | 1 -
> >  media-libs/libepoxy/metadata.xml             | 3 ---
> >  media-libs/libva-compat/metadata.xml         | 1 -
> >  media-plugins/gst-plugins-gtk/metadata.xml   | 1 -
> >  media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
> >  profiles/use.desc                            | 1 +
> >  11 files changed, 1 insertion(+), 12 deletions(-)
> >
> > diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-
> > plugins/gst-plugins-gtk/metadata.xml
> > index 7235f1bab7ba..f3b18c11bcfc 100644
> > --- a/media-plugins/gst-plugins-gtk/metadata.xml
> > +++ b/media-plugins/gst-plugins-gtk/metadata.xml
> > @@ -6,7 +6,6 @@
> >         <name>GStreamer package maintainers</name>
> >  </maintainer>
> >  <use>
> > -       <flag name="egl">Enable EGL platform usage</flag>
> >         <flag name="gles2">Enable gtkglsink OpenGL sink based on
> > GLESv2 API</flag>
> >         <flag name="opengl">Enable gtkglsink OpenGL sink based on
> > desktop OpenGL API</flag>
> >  </use>
>
> Please do not lose extra information provided in local descriptions in
> this and many other cases where you remove the local description (in
> other proposed global USE flag cases as well). Just don't remove the
> local description then. Thanks.
>

I've used my best judgment to figure out whether the local description
actually provides any "extra information". I didn't touch
the gtkglsink-related flags since they provided some information.
I fail to see how "platform usage" adds any information.

If you have "other proposed global USE flag cases" that are removing
information, please be more specific.

--
Best regards,
Micha? Górny

Attached Files:

Re: [PATCH 7/8] profiles/use.desc: Make USE=egl global [ In reply to ]
leio at gentoo
Dec 19, 2023, 12:23 PM
Post #4 of 4 (74 views)
Permalink
On Tue, 2023-12-19 at 12:50 +0100, Micha? Górny wrote:
> > > --- a/media-plugins/gst-plugins-gtk/metadata.xml
> > > +++ b/media-plugins/gst-plugins-gtk/metadata.xml
> > > @@ -6,7 +6,6 @@
> > >         <name>GStreamer package maintainers</name>
> > >  </maintainer>
> > >  <use>
> > > -       <flag name="egl">Enable EGL platform usage</flag>
> > >         <flag name="gles2">Enable gtkglsink OpenGL sink based on
> > > GLESv2 API</flag>
> > >         <flag name="opengl">Enable gtkglsink OpenGL sink based on
> > > desktop OpenGL API</flag>
> > >  </use>
> >
> > Please do not lose extra information provided in local descriptions
> > in this and many other cases where you remove the local description
> > (in other proposed global USE flag cases as well). Just don't
> > remove the local description then. Thanks.
> >
>
> I've used my best judgment to figure out whether the local
> description actually provides any "extra information".  I didn't
> touch the gtkglsink-related flags since they provided some
> information. I fail to see how "platform usage" adds any information.

With the tabs in the raw patch indent rendered as 8 spaces, my eyes
shifted (no less than on 3 looking occurrences while also trying to get
only this chunk into the reply) and I thought you are removing
precisely that gtkglsink comment, sorry!

> If you have "other proposed global USE flag cases" that are removing
> information, please be more specific.

I don't think any of these are very important, but if I were to
nitpick:

* x11-apps/mesa-progs local gles2 USE desc looked vaguely more useful
than the new global; might be even more useful if it named the
utilities by name (main one of interest is es2_info).
* "asm - Enable using assembly for optimization" reads a bit weird -
ultimately C, rust, etc end up using assembly in a way too. I would
have went with something more of the "Enable use of hand optimized
assembly routines" theme for the global desc.
* gnustep-base/gnustep-gui USE=speech seems to have told something
completely different than the global USE flag; maybe was looked into
and determined it's actually indeed text-to-speech* Some specify what
dep is used, but in many cases it's the obvious candidate. Maybe games-
engine/scummvm isn't that obvious. But users will see from the deptree.
* kde-apps/konqueror and net-misc/eventd specifies USE=speech installs
a plugin, which might be useful information IF that's something that
might need to be enabled by user on top to load the plugin. Not
important.


Mart

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal