Mailing List Archive: [RFC] xfconf.eclass - codename: keep it simple, stupid

[RFC] xfconf.eclass - codename: keep it simple, stupid

ssuominen at gentoo

Aug 1, 2009, 8:07 AM

Post #1 of 6 (570 views)

Right now, xfce ebuilds in tree are unmaintainable because:

- Eclass sets invalid license to pkgs, they all have different ones,
GPL-2, LGPL-2*, GPL-3, BSD

- Ebuilds have started using internal functions from both xfce44 and
xfce4 eclasses. Yes, some Xfce 4.6 ebuilds are still using xfce44.eclass.

- Upstream changed SRC_URI for plugins. It was a problem even before,
some plugins are in separate locations such as Xfce4 developers own
devspaces.

Just to mention some. It's complex, and not in a smart way.

We want to deprecate all of the xfce*.eclasses in tree and switch to
this simple template ebuild.

Please comment if there's something to change. Keep it simple.

Timeframe: If you agree, I or we will convert them in within 1-2 days
from now.

Thanks, Samuli

Re: [RFC] xfconf.eclass - codename: keep it simple, stupid [ In reply to ]

ssuominen at gentoo

Aug 1, 2009, 10:58 AM

Post #2 of 6 (517 views)

Samuli Suominen wrote:
> Please comment if there's something to change. Keep it simple.

Improved version attached. EAPI checking modification.

Thanks, Samuli

Re: [RFC] xfconf.eclass - codename: keep it simple, stupid [ In reply to ]

ciaran.mccreesh at googlemail

Aug 1, 2009, 10:59 AM

Post #3 of 6 (522 views)

On Sat, 01 Aug 2009 20:58:10 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:
> Improved version attached. EAPI checking modification.

> 2) EXPF+=" src_configure" ;;

+= is bash 3.1, which isn't legal for use in the tree.

--
Ciaran McCreesh

Re: [RFC] xfconf.eclass - codename: keep it simple, stupid [ In reply to ]

ssuominen at gentoo

Aug 1, 2009, 11:26 AM

Post #4 of 6 (516 views)

Ciaran McCreesh wrote:
> On Sat, 01 Aug 2009 20:58:10 +0300
> Samuli Suominen <ssuominen@gentoo.org> wrote:
>> Improved version attached. EAPI checking modification.
>
>> 2) EXPF+=" src_configure" ;;
>
> += is bash 3.1, which isn't legal for use in the tree.
>

It's been in use for a long time in xfce's ebuilds already, noone has
ever complained. One can easily match some hundreds of ebuilds in tree
where it's used.

Is this *really* a issue? If so, I have no trouble in reusing the var,
but it's ugly.

-Samuli

Re: [RFC] xfconf.eclass - codename: keep it simple, stupid [ In reply to ]

grobian at gentoo

Aug 1, 2009, 11:26 AM

Post #5 of 6 (518 views)

On 01-08-2009 21:26:09 +0300, Samuli Suominen wrote:
> Ciaran McCreesh wrote:
> > On Sat, 01 Aug 2009 20:58:10 +0300
> > Samuli Suominen <ssuominen@gentoo.org> wrote:
> >> Improved version attached. EAPI checking modification.
> >
> >> 2) EXPF+=" src_configure" ;;
> >
> > += is bash 3.1, which isn't legal for use in the tree.
> >
>
> It's been in use for a long time in xfce's ebuilds already, noone has
> ever complained. One can easily match some hundreds of ebuilds in tree
> where it's used.

http://archives.gentoo.org/gentoo-dev/msg_a5b81c2f60a80cc91e2a47a802168185.xml

> Is this *really* a issue? If so, I have no trouble in reusing the var,
> but it's ugly.

--
Fabian Groffen
Gentoo on a different level

Re: [RFC] xfconf.eclass - codename: keep it simple, stupid [ In reply to ]

ciaran.mccreesh at googlemail

Aug 1, 2009, 11:30 AM

Post #6 of 6 (510 views)

On Sat, 01 Aug 2009 21:26:09 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:
> > += is bash 3.1, which isn't legal for use in the tree.
>
> It's been in use for a long time in xfce's ebuilds already, noone has
> ever complained. One can easily match some hundreds of ebuilds in tree
> where it's used.

Yes, unfortunately it's impossible to get repoman to detect it reliably.

> Is this *really* a issue? If so, I have no trouble in reusing the var,
> but it's ugly.

It is. Unfortunately a whole bunch of developers moaned noisily when we
tried to fix the problem, so the tree's stuck with bash 3.0
indefinitely.

--
Ciaran McCreesh