Mailing List Archive: [kde-sunset] amarok 1.4 libmp4v2 patch needed

[kde-sunset] amarok 1.4 libmp4v2 patch needed

Dec 29, 2013, 5:17 AM

Post #1 of 3 (2174 views)

Hi. I'm "the other one" that is making some commits to the kde-sunset
overlay. Sorry for some messes ^^;

I use kde3 (sunset) on my notebook, while using kde4 on my desktop pc (even
if I'm very tempted to switch to something more useful - just now it's
"Konqueror & bloat DE" for me)

During last notebook update, I ended on the infamous "libmp4v2 frack-up"
problem.

Namely:
make[6]: *** [mp4tag.lo] Error 1
make[6]: *** Waiting for unfinished jobs....
mp4file.cpp: In member function 'virtual bool TagLib::MP4::File::save()':
mp4file.cpp:110:121: error: 'MP4GetMetadataCompilation' was not declared in
this scope
(and so on)

I found this problem is related to libmp4v2, which changed API | ABI and
then some programs stopped compile.
Here an example with mediatomb.
https://bugs.gentoo.org/show_bug.cgi?id=410235
There is a patch for Mediatomb in there.
Probably translating that patch to amarok may do the trick, but for now, I
don't have the actual time to (well, acquire c++ knowledge to and) make
that patch. Sorry for that.

I know there are some patches/ebuilds for kde-sunset that aren't in the
tree, and I'm trying to do my best to get anything I get to the tree. So,
in case there is someone who already made a patch for this, or someone who
is willing to make one even, can you reply to this? Thank you.

Keiji Costantini

Re: [kde-sunset] amarok 1.4 libmp4v2 patch needed [ In reply to ]

ejlddll at googlemail

Dec 29, 2013, 10:27 AM

Post #2 of 3 (2091 views)

Permalink

On Sun, 29 Dec 2013 14:17:30 +0100
Keiji Costantini <strites@gmail.com> wrote:

> I know there are some patches/ebuilds for kde-sunset that aren't in the
> tree, and I'm trying to do my best to get anything I get to the tree. So,
> in case there is someone who already made a patch for this, or someone who
> is willing to make one even, can you reply to this? Thank you.

Is this of any use? http://bugs.pearsoncomputing.net/show_bug.cgi?id=346
Problems with the MP4GetMetadata* functions are discussed starting in
comment 5, so I assume some level of relevance. There is unfortunately
no guarantee that the patch included will apply to vanilla Amarok sources,
but it might provide a starting point even if it doesn't.

E. Liddell

Re: [kde-sunset] amarok 1.4 libmp4v2 patch needed [ In reply to ]

strites at gmail

Dec 29, 2013, 5:16 PM

Post #3 of 3 (2096 views)

Permalink

2013/12/29 E. Liddell <ejlddll@googlemail.com>

> On Sun, 29 Dec 2013 14:17:30 +0100
> Keiji Costantini <strites@gmail.com> wrote:
>
> > I know there are some patches/ebuilds for kde-sunset that aren't in the
> > tree, and I'm trying to do my best to get anything I get to the tree. So,
> > in case there is someone who already made a patch for this, or someone
> who
> > is willing to make one even, can you reply to this? Thank you.
>
> Is this of any use? http://bugs.pearsoncomputing.net/show_bug.cgi?id=346
> Problems with the MP4GetMetadata* functions are discussed starting in
> comment 5, so I assume some level of relevance. There is unfortunately
> no guarantee that the patch included will apply to vanilla Amarok sources,
> but it might provide a starting point even if it doesn't.

Thank you for that. I just pushed an "r6" ebuild with a bunch of patches to
have it compiled on gcc 4.7.
I got it compile, if someone is going to test it, it's welcome :)

Now let's continue the "emerge -vuDaN world".....

Keiji Costantini

>
> E. Liddell
>
>