Mailing List Archive

[PATCH] amarok-1.4.10_p20090130-r4 fail to compile
Hi!

Error from build log:

---cut---
In file included from amarokdcophandler.cpp:36:0:
../../../amarok/src/osd.h: At global scope:
../../../amarok/src/osd.h:40:74: error: cannot call constructor 'QImage::QImage' directly
../../../amarok/src/osd.h:40:74: error: for a function-style cast, remove the redundant '::QImage'
---cut---

Patch (duplicated in attach):

---cut---
--- amarok/src/osd.h.orig 2011-09-27 17:47:26.000000000 +0300
+++ amarok/src/osd.h 2011-09-27 17:47:43.000000000 +0300
@@ -37,7 +37,7 @@

public slots:
/** calls setText() then show(), after setting image if needed */
- void show( const QString &text, QImage newImage = QImage::QImage() );
+ void show( const QString &text, QImage newImage = QImage() );
void ratingChanged( const short rating );
void ratingChanged( const QString& path, int rating );
void volChanged( unsigned char volume );
---cut---

I noticed this issue when re-emerging @world after upgrading gcc 4.4.5 to
4.5.3, but probably this issue have nothing with gcc and related to some
previous qt upgrade, so I named patch file amarok-qt3-4.7.patch but I'm
not sure this is correct name.

--
WBR, Alex.