Mailing List Archive

[Bug 646] New: carriage return in dovecot authenticator
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=646
Summary: carriage return in dovecot authenticator
Product: Exim
Version: 4.65
Platform: All
OS/Version: All
Status: NEW
Severity: bug
Priority: low
Component: SMTP Authentication
AssignedTo: nigel@exim.org
ReportedBy: km@krot.org
CC: exim-dev@exim.org


According to the specs (http://wiki.dovecot.org/Authentication_Protocol), the
Dovecot AUTH protocol is a line based protocol. Each line is a command which
ends with an LF character.

In src/auths/dovecot.c on line 326 there's a carriage return that should not be
there. Easy fix:

*** exim-4.69/src/auths/dovecot.c Sat Dec 22 00:58:48 2007
--- exim-4.69/src/auths/dovecot.c.orig Sat Dec 22 00:58:54 2007
***************
*** 323,329 ****
goto out;
}

! temp = string_sprintf("CONT\t%d\t%s\n", cuid, data);
if (write(fd, temp, Ustrlen(temp)) < 0)
OUT("authentication socket write error");
break;
--- 323,329 ----
goto out;
}

! temp = string_sprintf("CONT\t%d\t%s\r\n", cuid, data);
if (write(fd, temp, Ustrlen(temp)) < 0)
OUT("authentication socket write error");
break;


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##