Mailing List Archive

[Patch] RTCP length checking
Hi,

This patch includes the changes I previously sent in
http://www.ethereal.com/lists/ethereal-dev/200605/msg00208.html (I
assume it wasn't committed). The combined patch:

- shows profile-specific extension data at the end of SR/RR reports (if
packet length has not yet been reached after parsing normal data) and
advances offset (further packets were not recognised+dissected as this
data wasn't being skipped).
- checks that the length of the RTCP data in the whole frame matches the
combined length from the length fields (the last check in RFC 3550, "A.2
RTCP Header Validity Checks") with a generated field and expert info
when wrong.
- reports the length field in all of the message types consistently (the
length was confusingly shown multiplied by 4 only in APP packets...)

Best regards,
Martin
SV: [Patch] RTCP length checking [ In reply to ]
Checked in.
Please note that we are currently having some problems,
so the patch may not be in the public svn repo for a few days...
Brg
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@ethereal.com
[mailto:ethereal-dev-bounces@ethereal.com] För Martin Mathieson
Skickat: den 6 juni 2006 12:15
Till: Ethereal development
Ämne: [Ethereal-dev] [Patch] RTCP length checking

Hi,

This patch includes the changes I previously sent in
http://www.ethereal.com/lists/ethereal-dev/200605/msg00208.html (I
assume it wasn't committed). The combined patch:

- shows profile-specific extension data at the end of SR/RR reports (if
packet length has not yet been reached after parsing normal data) and
advances offset (further packets were not recognised+dissected as this
data wasn't being skipped).
- checks that the length of the RTCP data in the whole frame matches the
combined length from the length fields (the last check in RFC 3550, "A.2
RTCP Header Validity Checks") with a generated field and expert info
when wrong.
- reports the length field in all of the message types consistently (the
length was confusingly shown multiplied by 4 only in APP packets...)

Best regards,
Martin


_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-dev