Mailing List Archive: dbmail2/mozilla woes

dbmail2/mozilla woes

Mar 15, 2004, 11:21 AM

Post #1 of 11 (825 views)

Hi all,

Since there were no takers, I did a follow-up on my earlier conclusion
that the networking code could do with some improvements.

For those of you who haven't followed the list; dbmail2 won't work with
mozilla and derivatives.

I've wrapped the code talking to clients in simple wrappers with error
checking, and lo; mozilla suddenly works just fine with dbmail2 :-)

As a proof-of-concept I'm attaching my patch against the HEAD branch as
of today.

This is not for inclusion in CVS just yet. It's still kind of rough, but
I wanted to share my relief that this really does appear to fix the bug.
Also, pop3.c and lmtpd.c would probably also benefit from this approach
as well.

IMO imap4.c and friends could do with some re-indenting. Looks like
there are several different indent-styles intertwined in the code. Any
consensus on that regard ?

--
________________________________________________________________
Paul Stevens mailto:paul@nfg.nl
NET FACILITIES GROUP PGP: finger paul@nfg.nl
The Netherlands________________________________http://www.nfg.nl

Re: dbmail2/mozilla woes [ In reply to ]

polito at blackbeanie

Mar 15, 2004, 11:55 AM

Post #2 of 11 (812 views)

Permalink

I've had to work on imap and friends extensively for my company and yes, the indenting is different in different places and drives me batty. Definitely would be nice to figure out a standard indentation and keep to it.

On Mon, Mar 15, 2004 at 07:21:19PM +0100, Paul J Stevens wrote:
> IMO imap4.c and friends could do with some re-indenting. Looks like
> there are several different indent-styles intertwined in the code. Any
> consensus on that regard ?

Re: dbmail2/mozilla woes [ In reply to ]

aaron at serendipity

Mar 15, 2004, 12:19 PM

Post #3 of 11 (817 views)

Permalink

This is really, really good... I wonder if it can be combined with a macro or
built into a macro so that the "if (ci_write) return -1" could be "ci_write"
and since there's only ever one stream to write, "ci->tx" could be assumed.

The LMTP code doesn't use the ClientInfo structure, but in the process of
refactoring the server code these sorts of micro-differences should be brought
together so that the ClientInfo structure is either generic enough or beefy
enough (just toss all of the different elements into it) to handle IMAP, POP,
LMTP, and whatever else comes next (NNTP anyone? ;-)

Aaron

Paul J Stevens <paul@nfg.nl> said:

>
> Hi all,
>
> Since there were no takers, I did a follow-up on my earlier conclusion
> that the networking code could do with some improvements.
>
> For those of you who haven't followed the list; dbmail2 won't work with
> mozilla and derivatives.
>
> I've wrapped the code talking to clients in simple wrappers with error
> checking, and lo; mozilla suddenly works just fine with dbmail2 :-)
>
> As a proof-of-concept I'm attaching my patch against the HEAD branch as
> of today.
>
> This is not for inclusion in CVS just yet. It's still kind of rough, but
> I wanted to share my relief that this really does appear to fix the bug.
> Also, pop3.c and lmtpd.c would probably also benefit from this approach
> as well.
>
> IMO imap4.c and friends could do with some re-indenting. Looks like
> there are several different indent-styles intertwined in the code. Any
> consensus on that regard ?
>
>
> --
> ________________________________________________________________
> Paul Stevens mailto:paul@nfg.nl
> NET FACILITIES GROUP PGP: finger paul@nfg.nl
> The Netherlands________________________________http://www.nfg.nl
>
>

--

Re: dbmail2/mozilla woes [ In reply to ]

ed at hp

Mar 15, 2004, 12:32 PM

Post #4 of 11 (812 views)

Permalink

Let me know when the NNTP service starts development.
No other NNTP servers that I've found use a RDBMS backend.

ed

On Mon, 15 Mar 2004, Aaron Stone wrote:

> This is really, really good... I wonder if it can be combined with a macro or
> built into a macro so that the "if (ci_write) return -1" could be "ci_write"
> and since there's only ever one stream to write, "ci->tx" could be assumed.
>
> The LMTP code doesn't use the ClientInfo structure, but in the process of
> refactoring the server code these sorts of micro-differences should be brought
> together so that the ClientInfo structure is either generic enough or beefy
> enough (just toss all of the different elements into it) to handle IMAP, POP,
> LMTP, and whatever else comes next (NNTP anyone? ;-)
>
> Aaron
>
>
> Paul J Stevens <paul@nfg.nl> said:
>
> >
> > Hi all,
> >
> > Since there were no takers, I did a follow-up on my earlier conclusion
> > that the networking code could do with some improvements.
> >
> > For those of you who haven't followed the list; dbmail2 won't work with
> > mozilla and derivatives.
> >
> > I've wrapped the code talking to clients in simple wrappers with error
> > checking, and lo; mozilla suddenly works just fine with dbmail2 :-)
> >
> > As a proof-of-concept I'm attaching my patch against the HEAD branch as
> > of today.
> >
> > This is not for inclusion in CVS just yet. It's still kind of rough, but
> > I wanted to share my relief that this really does appear to fix the bug.
> > Also, pop3.c and lmtpd.c would probably also benefit from this approach
> > as well.
> >
> > IMO imap4.c and friends could do with some re-indenting. Looks like
> > there are several different indent-styles intertwined in the code. Any
> > consensus on that regard ?
> >
> >
> > --
> > ________________________________________________________________
> > Paul Stevens mailto:paul@nfg.nl
> > NET FACILITIES GROUP PGP: finger paul@nfg.nl
> > The Netherlands________________________________http://www.nfg.nl
> >
> >
>
>
>
> --
>
>
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

Security on the internet is impossible without strong, open,
and unhindered encryption.

Re: dbmail2/mozilla woes [ In reply to ]

ljackson at jjcons

Mar 15, 2004, 12:49 PM

Post #5 of 11 (808 views)

Permalink

Ed, For good reason,

I used to work for one of the worlds largest NNTP providers. And believe
me from experience we do not want to get into NNTP stuff. The reason none
of the currently available NNTP server code uses an RDBM is that the file
IO is so heavy and requires so much IO that it takes all of a fiber
channel disk system and Sun 420R's with 4G of ram to keep up with a full
NNTP feed. Much less serve any end users. Roughly about 65Mbps (to
90Mbps) for a full feed now, scary eh?

my suggestion is to leave nntp alone :)

-leif

> Let me know when the NNTP service starts development.
> No other NNTP servers that I've found use a RDBMS backend.
>
> ed
>
> On Mon, 15 Mar 2004, Aaron Stone wrote:
>
>> This is really, really good... I wonder if it can be combined with a
>> macro or
>> built into a macro so that the "if (ci_write) return -1" could be
>> "ci_write"
>> and since there's only ever one stream to write, "ci->tx" could be
>> assumed.
>>
>> The LMTP code doesn't use the ClientInfo structure, but in the process
>> of
>> refactoring the server code these sorts of micro-differences should be
>> brought
>> together so that the ClientInfo structure is either generic enough or
>> beefy
>> enough (just toss all of the different elements into it) to handle IMAP,
>> POP,
>> LMTP, and whatever else comes next (NNTP anyone? ;-)
>>
>> Aaron
>>
>>
>> Paul J Stevens <paul@nfg.nl> said:
>>
>> >
>> > Hi all,
>> >
>> > Since there were no takers, I did a follow-up on my earlier conclusion
>> > that the networking code could do with some improvements.
>> >
>> > For those of you who haven't followed the list; dbmail2 won't work
>> with
>> > mozilla and derivatives.
>> >
>> > I've wrapped the code talking to clients in simple wrappers with error
>> > checking, and lo; mozilla suddenly works just fine with dbmail2 :-)
>> >
>> > As a proof-of-concept I'm attaching my patch against the HEAD branch
>> as
>> > of today.
>> >
>> > This is not for inclusion in CVS just yet. It's still kind of rough,
>> but
>> > I wanted to share my relief that this really does appear to fix the
>> bug.
>> > Also, pop3.c and lmtpd.c would probably also benefit from this
>> approach
>> > as well.
>> >
>> > IMO imap4.c and friends could do with some re-indenting. Looks like
>> > there are several different indent-styles intertwined in the code. Any
>> > consensus on that regard ?
>> >
>> >
>> > --
>> > ________________________________________________________________
>> > Paul Stevens mailto:paul@nfg.nl
>> > NET FACILITIES GROUP PGP: finger paul@nfg.nl
>> > The Netherlands________________________________http://www.nfg.nl
>> >
>> >
>>
>>
>>
>> --
>>
>>
>>
>> _______________________________________________
>> Dbmail-dev mailing list
>> Dbmail-dev@dbmail.org
>> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>>
>
> Security on the internet is impossible without strong, open,
> and unhindered encryption.
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

Re: dbmail2/mozilla woes [ In reply to ]

aaron at serendipity

Mar 15, 2004, 1:01 PM

Post #6 of 11 (814 views)

Permalink

On more fundamental open source grounds, requests like these are generally
just useless noise. Development happens when someone wants some software to do
x,y,z task, cannot find anything to their liking, and so the person then goes
and writes the software themselves. If they share it with others, that's when
you get open source!

I've always wanted to have a simple local news server that was also easily
connected to a web forum. The lack of any sort of standardization among
forums, or worse, the ones that try to use DAV and XML to "share" drives me
nuts. So I've never had my small little news site. That's the itch that I
might scratch by writing an NNTP server.

Leif's advice is well taken, though. Usenet is a scary place to be; I've seen
the news servers at my local ISP keep the access lights on a RAID array
solidly lit all day and all night. And it's a small ISP.

Aaron

""Leif Jackson"" <ljackson@jjcons.com> said:

> Ed, For good reason,
>
> I used to work for one of the worlds largest NNTP providers. And believe
> me from experience we do not want to get into NNTP stuff. The reason none
> of the currently available NNTP server code uses an RDBM is that the file
> IO is so heavy and requires so much IO that it takes all of a fiber
> channel disk system and Sun 420R's with 4G of ram to keep up with a full
> NNTP feed. Much less serve any end users. Roughly about 65Mbps (to
> 90Mbps) for a full feed now, scary eh?
>
> my suggestion is to leave nntp alone :)
>
> -leif
>
> > Let me know when the NNTP service starts development.
> > No other NNTP servers that I've found use a RDBMS backend.
> >
> > ed
> >
> > On Mon, 15 Mar 2004, Aaron Stone wrote:
> >
> >> This is really, really good... I wonder if it can be combined with a
> >> macro or
> >> built into a macro so that the "if (ci_write) return -1" could be
> >> "ci_write"
> >> and since there's only ever one stream to write, "ci->tx" could be
> >> assumed.
> >>
> >> The LMTP code doesn't use the ClientInfo structure, but in the process
> >> of
> >> refactoring the server code these sorts of micro-differences should be
> >> brought
> >> together so that the ClientInfo structure is either generic enough or
> >> beefy
> >> enough (just toss all of the different elements into it) to handle IMAP,
> >> POP,
> >> LMTP, and whatever else comes next (NNTP anyone? ;-)
> >>
> >> Aaron
> >>
> >>
> >> Paul J Stevens <paul@nfg.nl> said:
> >>
> >> >
> >> > Hi all,
> >> >
> >> > Since there were no takers, I did a follow-up on my earlier conclusion
> >> > that the networking code could do with some improvements.
> >> >
> >> > For those of you who haven't followed the list; dbmail2 won't work
> >> with
> >> > mozilla and derivatives.
> >> >
> >> > I've wrapped the code talking to clients in simple wrappers with error
> >> > checking, and lo; mozilla suddenly works just fine with dbmail2 :-)
> >> >
> >> > As a proof-of-concept I'm attaching my patch against the HEAD branch
> >> as
> >> > of today.
> >> >
> >> > This is not for inclusion in CVS just yet. It's still kind of rough,
> >> but
> >> > I wanted to share my relief that this really does appear to fix the
> >> bug.
> >> > Also, pop3.c and lmtpd.c would probably also benefit from this
> >> approach
> >> > as well.
> >> >
> >> > IMO imap4.c and friends could do with some re-indenting. Looks like
> >> > there are several different indent-styles intertwined in the code. Any
> >> > consensus on that regard ?
> >> >
> >> >
> >> > --
> >> > ________________________________________________________________
> >> > Paul Stevens mailto:paul@nfg.nl
> >> > NET FACILITIES GROUP PGP: finger paul@nfg.nl
> >> > The Netherlands________________________________http://www.nfg.nl
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >>
> >>
> >>
> >> _______________________________________________
> >> Dbmail-dev mailing list
> >> Dbmail-dev@dbmail.org
> >> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> >>
> >
> > Security on the internet is impossible without strong, open,
> > and unhindered encryption.
> >
> > _______________________________________________
> > Dbmail-dev mailing list
> > Dbmail-dev@dbmail.org
> > http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> >
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

--

Re: dbmail2/mozilla woes [ In reply to ]

ilja at ic-s

Mar 16, 2004, 2:24 AM

Post #7 of 11 (811 views)

Permalink

I've been thinking about running indent on all code. It's turned in to a
bit of a mess lately. Mostly my wrong.

I prefer using K&R indentation style, I think it's the most readable.
Any opinions on this?

Ilja

Paul F. De La Cruz wrote:

> I've had to work on imap and friends extensively for my company and yes, the indenting is different in different places and drives me batty. Definitely would be nice to figure out a standard indentation and keep to it.
>
> On Mon, Mar 15, 2004 at 07:21:19PM +0100, Paul J Stevens wrote:
>
>>IMO imap4.c and friends could do with some re-indenting. Looks like
>>there are several different indent-styles intertwined in the code. Any
>>consensus on that regard ?
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev

Re: dbmail2/mozilla woes [ In reply to ]

ilja at ic-s

Mar 16, 2004, 2:46 AM

Post #8 of 11 (812 views)

Permalink

Hi

Paul J Stevens wrote:

>
> Hi all,
>
> Since there were no takers, I did a follow-up on my earlier conclusion
> that the networking code could do with some improvements.
>
> For those of you who haven't followed the list; dbmail2 won't work with
> mozilla and derivatives.
Well, it does work here, but only after applying some changes in the ACL
commands (which I did last Friday). By the way, I've used Mozilla
Thunderbird 0.5, and Mozilla Mail from the Mozilla 1.5 suite.
>
> I've wrapped the code talking to clients in simple wrappers with error
> checking, and lo; mozilla suddenly works just fine with dbmail2 :-)
Was that before or after using the renewed ACL code I added?
>
> As a proof-of-concept I'm attaching my patch against the HEAD branch as
> of today.
>
> This is not for inclusion in CVS just yet. It's still kind of rough, but
> I wanted to share my relief that this really does appear to fix the bug.
> Also, pop3.c and lmtpd.c would probably also benefit from this approach
> as well.

I like the way your code works. This is definitly something we can use
for our other daemons.
>
> IMO imap4.c and friends could do with some re-indenting. Looks like
> there are several different indent-styles intertwined in the code. Any
> consensus on that regard ?
Yep. I'd like to run indent -kr on those files. It's my wrong the
indenting is screwed up by the way.

Ilja

Re: dbmail2/mozilla woes [ In reply to ]

aaron at serendipity

Mar 16, 2004, 12:08 PM

Post #9 of 11 (814 views)

Permalink

I'm a fan of GNU style, with two spaces between levels and curly braces on
intermediary levels by themselves. All but their stupid function format.
Nobody should have to #ifdef every single function with K&R compatibility;
that's just dumb.

Sounds like you want:
http://pantransit.reptiles.org/prog/CodingStyle.html

But, despite the suggestion to burn them, I really like most of:
http://www.gnu.org/prep/standards_23.html

Aaron

Ilja Booij <ilja@ic-s.nl> said:

> I've been thinking about running indent on all code. It's turned in to a
> bit of a mess lately. Mostly my wrong.
>
> I prefer using K&R indentation style, I think it's the most readable.
> Any opinions on this?
>
> Ilja
>
>
> Paul F. De La Cruz wrote:
>
> > I've had to work on imap and friends extensively for my company and yes,
the indenting is different in different places and drives me batty. Definitely
would be nice to figure out a standard indentation and keep to it.
> >
> > On Mon, Mar 15, 2004 at 07:21:19PM +0100, Paul J Stevens wrote:
> >
> >>IMO imap4.c and friends could do with some re-indenting. Looks like
> >>there are several different indent-styles intertwined in the code. Any
> >>consensus on that regard ?
> >
> > _______________________________________________
> > Dbmail-dev mailing list
> > Dbmail-dev@dbmail.org
> > http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

--

Re: dbmail2/mozilla woes [ In reply to ]

ilja at ic-s

Mar 18, 2004, 4:32 AM

Post #10 of 11 (806 views)

Permalink

I like the Linux kernel coding style. To me, it's much more readable
than GNU style, but that's just a matter of familiarity I guess.

Does anybody have objections if I run indent -i8 -kr on the code now,
and release RC4 after that?

Ilja

Aaron Stone wrote:
> I'm a fan of GNU style, with two spaces between levels and curly braces on
> intermediary levels by themselves. All but their stupid function format.
> Nobody should have to #ifdef every single function with K&R compatibility;
> that's just dumb.
>
> Sounds like you want:
> http://pantransit.reptiles.org/prog/CodingStyle.html
>
> But, despite the suggestion to burn them, I really like most of:
> http://www.gnu.org/prep/standards_23.html
>
> Aaron
>
>
> Ilja Booij <ilja@ic-s.nl> said:
>
>
>>I've been thinking about running indent on all code. It's turned in to a
>>bit of a mess lately. Mostly my wrong.
>>
>>I prefer using K&R indentation style, I think it's the most readable.
>>Any opinions on this?
>>
>>Ilja
>>
>>
>>Paul F. De La Cruz wrote:
>>
>>
>>>I've had to work on imap and friends extensively for my company and yes,
>
> the indenting is different in different places and drives me batty. Definitely
> would be nice to figure out a standard indentation and keep to it.
>
>>>On Mon, Mar 15, 2004 at 07:21:19PM +0100, Paul J Stevens wrote:
>>>
>>>
>>>>IMO imap4.c and friends could do with some re-indenting. Looks like
>>>>there are several different indent-styles intertwined in the code. Any
>>>>consensus on that regard ?
>>>
>>>_______________________________________________
>>>Dbmail-dev mailing list
>>>Dbmail-dev@dbmail.org
>>>http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>>
>>_______________________________________________
>>Dbmail-dev mailing list
>>Dbmail-dev@dbmail.org
>>http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>>
>
>
>
>

Re: dbmail2/mozilla woes [ In reply to ]

polito at blackbeanie

Mar 18, 2004, 5:21 AM

Post #11 of 11 (810 views)

Permalink

I might have some objections, but not any particularly valid ones :D Hmm... think I'll run indent -i8 -kr on some of the code I've been working on and see what it looks like.. hmm.

Hmm.. I wonder if that'll make things a lot more difficult to merge into our private cvs copy of dbmail... hrmm...

On Thu, Mar 18, 2004 at 12:32:01PM +0100, Ilja Booij wrote:
> I like the Linux kernel coding style. To me, it's much more readable
> than GNU style, but that's just a matter of familiarity I guess.
>
> Does anybody have objections if I run indent -i8 -kr on the code now,
> and release RC4 after that?
>
> Ilja

Mailing List Archive

Mailing List Archive

Attached Files: