Mailing List Archive

On 09/20/2013 02:29 PM, Pavlo Lavrenenko wrote:
> Hi, Paul. Is there any policy in master to dbmail_3_1 commits picking
> you follow?

Not really.

> As I can see 083c550 and edbf08c were merged into master branch only, I
> assume I should have created pull requests for dbmail_3_1 as well for
> them to appear in 3.1.X releases?

No need.



--
________________________________________________________________
Paul J Stevens pjstevns @ gmail, twitter, skype, linkedin

* Premium Hosting Services and Web Application Consultancy *

www.nfg.nl/info@nfg.nl/+31.85.877.99.97
________________________________________________________________
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

On 09/20/2013 04:09 PM, Paul J Stevens wrote:
>> As I can see 083c550 and edbf08c were merged into master branch only, I
>> assume I should have created pull requests for dbmail_3_1 as well for
>> them to appear in 3.1.X releases?
>
> No need.

Hm... Will I get lucky to see them in the nearest 3.1.7 release? :)
I also have a couple of bugfixes kept from 3.0 branch which should be useful in
upstream. Is there any chance to push them into 3.1 branch? I will prepare pull
requests is its possible.

--
Best regards,
Pavlo Lavrenenko,
PortaOne, Inc., Junior Software Developer
Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624

PortaOne - VoIP Solutions Company
Visit our Website: http://www.portaone.com
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

On 09/20/2013 03:15 PM, Pavlo Lavrenenko wrote:
> On 09/20/2013 04:09 PM, Paul J Stevens wrote:
>>> As I can see 083c550 and edbf08c were merged into master branch only, I
>>> assume I should have created pull requests for dbmail_3_1 as well for
>>> them to appear in 3.1.X releases?
>>
>> No need.
>
> Hm... Will I get lucky to see them in the nearest 3.1.7 release? :)

Yes

> I also have a couple of bugfixes kept from 3.0 branch which should be
> useful in upstream. Is there any chance to push them into 3.1 branch? I
> will prepare pull requests is its possible.

That depends. They will go into master if they are indeed useful. Only
if they fix important bugs or are trivial, and don't require schema
changes will I consider them for 3.1



--
________________________________________________________________
Paul J Stevens pjstevns @ gmail, twitter, skype, linkedin

* Premium Hosting Services and Web Application Consultancy *

www.nfg.nl/info@nfg.nl/+31.85.877.99.97
________________________________________________________________s
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

On 09/20/2013 04:21 PM, Paul J Stevens wrote:
> That depends. They will go into master if they are indeed useful. Only
> if they fix important bugs or are trivial, and don't require schema
> changes will I consider them for 3.1

Got it, I will publish what I have.
Till than, can you please pick next chunk from 6e8be984:

diff --git a/src/dm_message.c b/src/dm_message.c
index a0a0bb7..0cd33bd 100644
--- a/src/dm_message.c
+++ b/src/dm_message.c
@@ -496,8 +496,8 @@ static DbmailMessage * _mime_retrieve(DbmailMessage *self)
END_TRY;

if ((row == 0) || (t == DM_EQUERY)) {
- if (m)
- p_string_free(m,TRUE);
+ if (m) p_string_free(m, TRUE);
+ if (n) p_string_free(n, TRUE);
return NULL;
}


I guess a small memory leak fix is always appreciated.

--
Best regards,
Pavlo Lavrenenko,
PortaOne, Inc., Junior Software Developer
Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624

PortaOne - VoIP Solutions Company
Visit our Website: http://www.portaone.com
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

Hi, Paul. I've left thee pull requests, please review:
https://github.com/pjstevns/dbmail/pull/3
https://github.com/pjstevns/dbmail/pull/4
https://github.com/pjstevns/dbmail/pull/5

Btw should I bother you with github links in dbmail-dev? Github seems to have
its own notifications.

--
Best regards,
Pavlo Lavrenenko,
PortaOne, Inc., Junior Software Developer
Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624

PortaOne - VoIP Solutions Company
Visit our Website: http://www.portaone.com
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

On 09/20/2013 05:55 PM, Pavlo Lavrenenko wrote:
> Hi, Paul. I've left thee pull requests, please review:
> https://github.com/pjstevns/dbmail/pull/3
> https://github.com/pjstevns/dbmail/pull/4
> https://github.com/pjstevns/dbmail/pull/5
>
> Btw should I bother you with github links in dbmail-dev? Github seems to have
> its own notifications.
>

Paul, thanks for feedback, changes from pull request is indeed present in master
and dbmail_3_1 branches, I've missed that.

Still where are the changes from 3 and 5? You've commented pull requests with
`merged' but commits don't seem to appear anywhere.

Also what about the chunk from 6e8be984 (see my previous mail)?

Sorry for my pings but I am planning to update from 3.0.2 to 3.1.7 when its
released and get rid of a huge patchset I keep carrying for years. Unfortunately
there is no reliable workflow and/or milestones so I don't know when and what to
expect.

--
Best regards,
Pavlo Lavrenenko,
PortaOne, Inc., Junior Software Developer
Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624

PortaOne - VoIP Solutions Company
Visit our Website: http://www.portaone.com
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

On 23-09-13 12:35, Pavlo Lavrenenko wrote:
> Paul, thanks for feedback, changes from pull request is indeed present
> in master and dbmail_3_1 branches, I've missed that.
>
> Still where are the changes from 3 and 5? You've commented pull requests
> with `merged' but commits don't seem to appear anywhere.
>
> Also what about the chunk from 6e8be984 (see my previous mail)?

I merged it all, but forgot to push. Will do so once I get my hands on
my laptop again.




--
________________________________________________________________
Paul J Stevens pjstevns @ gmail, twitter, skype, linkedin

* Premium Hosting Services and Web Application Consultancy *

www.nfg.nl/info@nfg.nl/+31.85.877.99.97
________________________________________________________________
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev