Mailing List Archive

[6844] cherokee/trunk/cherokee/common-internal.h: Valgrind was complaining about pthread_rwlock_init() accessing
Revision: 6844
http://svn.cherokee-project.com/changeset/6844
Author: alo
Date: 2011-09-14 10:31:22 +0200 (Wed, 14 Sep 2011)
Log Message:
-----------
Valgrind was complaining about pthread_rwlock_init() accessing
uninitialized memory. I doubt this solves any real problem, although
it does not hurt either.

Modified Paths:
--------------
cherokee/trunk/cherokee/common-internal.h

Modified: cherokee/trunk/cherokee/common-internal.h
===================================================================
--- cherokee/trunk/cherokee/common-internal.h 2011-09-13 15:19:21 UTC (rev 6843)
+++ cherokee/trunk/cherokee/common-internal.h 2011-09-14 08:31:22 UTC (rev 6844)
@@ -118,7 +118,10 @@
# define CHEROKEE_MUTEX_DESTROY(m) pthread_mutex_destroy(m)
# define CHEROKEE_MUTEX_TRY_LOCK(m) pthread_mutex_trylock(m)

-# define CHEROKEE_RWLOCK_INIT(m,n) pthread_rwlock_init(m,n)
+# define CHEROKEE_RWLOCK_INIT(m,n) do { \
+ memset (m, 0, sizeof(pthread_rwlock_t)); \
+ pthread_rwlock_init(m,n); \
+ } while(0)
# define CHEROKEE_RWLOCK_READER(m) pthread_rwlock_rdlock(m)
# define CHEROKEE_RWLOCK_WRITER(m) pthread_rwlock_wrlock(m)
# define CHEROKEE_RWLOCK_TRYREADER(m) pthread_rwlock_tryrdlock(m)