Mailing List Archive: Setting config after setup has been run is not allowed.

I'm confused about this rather stern note in Catalyst.pm.

Is this the following wrapper related to the text in the NOTE?

B<NOTE:> you MUST NOT call C<< $self->config >> or C<< __PACKAGE__->config
>>
as a way of reading config within your code, as this B<will not> give you
the
correctly merged config back. You B<MUST> take the config values supplied to
the constructor and use those instead.

=cut

around config => sub {
my $orig = shift;
my $c = shift;

croak('Setting config after setup has been run is not allowed.')
if ( @_ and $c->setup_finished );

$c->$orig(@_);
};

I understand the NOTE for Model/View/Controllers where the component's
__PACKAGE__->config is merged in with the application config for that
component. Calling $self->config won't be the same thing passed to the
component's constructor.

But, what's the issue with calling $c->config( foo => 123 ) at runtime?
Or even $c->config( \%new_config )?

Note that wrapper only applies to calling config on the app class, and does
not apply to Model/View/Controllers.

Is there some other issues I'm missing? What problem is that wrapper
trying to prevent?

Thanks,

--
Bill Moseley
moseley@hank.org

You shouldn't try to change the configuration once setup if finished since at that point everything has been initialized. Â if you change stuff there its not going to do anything. Â Whats the actual use case you are trying to achieve here.
FWIW Calling $c->config for application scoped stuff is ok I believe (no change, just getting the data). Â For example if I really need to do a plugin, I usually do like:
my $adaptor_namespace = sub {Â my $app = shift;Â if(my $config = $app->config->{'Plugin::InjectionHelpers'}) {Â Â my $namespace = $config->{adaptor_namespace};Â Â return $namespace if $namespace;Â }Â return 'Catalyst::Model::InjectionHelpers';};
to create a way for the plugin to have stuff in the config. Â In this case I also created an anonymous code ref instead of a normal method so that the plugin would not pollute the application namespace so much.

On Friday, September 25, 2015 8:40 AM, Bill Moseley <moseley@hank.org> wrote:

I'm confused about this rather stern note in Catalyst.pm.
Is this the following wrapper related to the text in the NOTE?

B<NOTE:> you MUST NOT call C<< $self->config >> or C<< __PACKAGE__->config >>as a way of reading config within your code, as this B<will not> give you thecorrectly merged config back. You B<MUST> take the config values supplied tothe constructor and use those instead.
=cut
around config => sub {Â Â my $orig = shift;Â Â my $c = shift;
Â Â croak('Setting config after setup has been run is not allowed.')Â Â Â Â if ( @_ and $c->setup_finished );
Â Â $c->$orig(@_);};

I understand the NOTE for Model/View/Controllers where the component's __PACKAGE__->config is merged in with the application config for that component. Â Calling $self->config won't be the same thing passed to the component's constructor.
But, what's the issue with calling $c->config( foo => 123 ) at runtime? Â Or even $c->config( \%new_config )? Â Â
Note that wrapper only applies to calling config on the app class, and does not apply to Model/View/Controllers.
Is there some other issues I'm missing? Â What problem is that wrapper trying to prevent?
Thanks,

--
Bill Moseley
moseley@hank.org
_______________________________________________
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/