Branch: refs/heads/master
Home: https://github.com/bricoleurs/bricolage
Commit: 9c802d12950b2d4bb42b58aadf24e36db67c6fee
https://github.com/bricoleurs/bricolage/commit/9c802d12950b2d4bb42b58aadf24e36db67c6fee
Author: David E. Wheeler <david@justatheory.com>
Date: 2011-08-16 (Tue, 16 Aug 2011)
Changed paths:
M lib/Bric/App/Callback/Desk.pm
M lib/Bric/App/Callback/Profile/Story.pm
M lib/Bric/Util/Burner.pm
Log Message:
-----------
Move fixes for Bug #277.
With `PUBLISH_RELATED_FAIL_BEHAVIOR = fail`, things work fine now when publishing via "Check in and Publish" in the story profile and when selecting that option on a desk or workflow, which is an Ajax call.
One side effect is that if the publish fails because the story itself fails to publish (rather than because a related fails), the story is instantly checked out to the user again and put back into workflow. In the interrim, the asset will have been checked in, so the result is a new version number. I think that this is a very minor issue that most folks won't even notice, and is far better than what we had, where things were checked in and sometimes removed from workflow. This is better: other than the new version, it looks like the same page as before, with all the same data, but a nice status message explaining the failure.
In order to properly catch an error when there are no destinations, that exception is now thorwn as an "invalid error" exception rather than a fatal exception. That indicates that it's something to inform the user of, rather than something unexpected (which is a 500). Looking at it, I think it was silly to have been throwing a burn error for that particular error; an invalid error is a much better choice.
Still to do to finish fixing this bug:
* Fix media to follow the same pattern.
* Make sure that `PUBLISH_RELATED_FAIL_BEHAVIOR = warn` works as expected
* Make sure that publishing from search results works as expected
* Make sure that bulk publish works as expected.
* Make sure all tests continue to pass.
[#277 state:open]
Home: https://github.com/bricoleurs/bricolage
Commit: 9c802d12950b2d4bb42b58aadf24e36db67c6fee
https://github.com/bricoleurs/bricolage/commit/9c802d12950b2d4bb42b58aadf24e36db67c6fee
Author: David E. Wheeler <david@justatheory.com>
Date: 2011-08-16 (Tue, 16 Aug 2011)
Changed paths:
M lib/Bric/App/Callback/Desk.pm
M lib/Bric/App/Callback/Profile/Story.pm
M lib/Bric/Util/Burner.pm
Log Message:
-----------
Move fixes for Bug #277.
With `PUBLISH_RELATED_FAIL_BEHAVIOR = fail`, things work fine now when publishing via "Check in and Publish" in the story profile and when selecting that option on a desk or workflow, which is an Ajax call.
One side effect is that if the publish fails because the story itself fails to publish (rather than because a related fails), the story is instantly checked out to the user again and put back into workflow. In the interrim, the asset will have been checked in, so the result is a new version number. I think that this is a very minor issue that most folks won't even notice, and is far better than what we had, where things were checked in and sometimes removed from workflow. This is better: other than the new version, it looks like the same page as before, with all the same data, but a nice status message explaining the failure.
In order to properly catch an error when there are no destinations, that exception is now thorwn as an "invalid error" exception rather than a fatal exception. That indicates that it's something to inform the user of, rather than something unexpected (which is a 500). Looking at it, I think it was silly to have been throwing a burn error for that particular error; an invalid error is a much better choice.
Still to do to finish fixing this bug:
* Fix media to follow the same pattern.
* Make sure that `PUBLISH_RELATED_FAIL_BEHAVIOR = warn` works as expected
* Make sure that publishing from search results works as expected
* Make sure that bulk publish works as expected.
* Make sure all tests continue to pass.
[#277 state:open]