Mailing List Archive

Branch: refs/heads/master
Home: http://github.com/bricoleurs/bricolage

Commit: 256e5509a54adb83253e190be26f948ca741efd1
http://github.com/bricoleurs/bricolage/commit/256e5509a54adb83253e190be26f948ca741efd1
Author: David E. Wheeler <david@justatheory.com>
Date: 2010-07-06 (Tue, 06 Jul 2010)

Changed paths:
M lib/Bric/Admin.pod
M lib/Bric/Changes.pod
M lib/Bric/Util/Trans/SFTP.pm
A t/Bric/Util/Trans/FTP/Test.pm
A t/Bric/Util/Trans/SFTP/Test.pm

Log Message:
-----------
Refactor Bric::Util::Trans::SFTP.

It was a bit of a mess. Much of the code was unnecessary, dating from before
2.0 when it used Net::SFTP instead of Net::SSH2. As a result, the error
handling was all wrong.

While at it, remove the file name escaping, as with newer versions of
Net::SSH2 at least (or perhaps newer versions of libssh2), it was leaving the
backslashes in the file names on the destination server. So bump up the
minimum version of Net::SSH2.

For sanity, also add tests to make sure that Net::Util::Trans::SFTP and
Net::Util::Trans::SFTP compile and have apprpropriate interfaces.