Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Bricolage>
  3. bugs
[Bricolage #206] Keyword Autocomplete includes deleted keywords
no-reply at lighthouseapp
Oct 12, 2010, 2:59 PM
Post #1 of 6 (2274 views)
Permalink
// Add your reply above here
==================================================
Greg Heo updated this ticket at October 12th, 2010 @ 09:59 PM

Fixing this opened up a couple of other issues for me:

1. A user can add a deleted keyword back to a story. This does not reactivate the keyword so it appears in the story profile but not in the keyword browser. Proposed fix: reactivate the keyword.

2. There's no way to search for or reactivate deleted keywords. Proposed enhancement: add a "include deleted" flag to the keyword browser and a "reactivate" link on the search results.

Reasonable?
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.1
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #206] Keyword Autocomplete includes deleted keywords [ In reply to ]
no-reply at lighthouseapp
Oct 12, 2010, 3:06 PM
Post #2 of 6 (2226 views)
Permalink
// Add your reply above here
==================================================
theory updated this ticket at October 12th, 2010 @ 10:06 PM

1. I think it'd be better to have the autosuggest have `active => 1` in its query. That way it won't be automatically suggested. If the user types it in anyway, yes, re-activate it.

2. Yes.

Best,

David
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.1
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #206] Keyword Autocomplete includes deleted keywords [ In reply to ]
no-reply at lighthouseapp
Oct 12, 2010, 7:15 PM
Post #3 of 6 (2216 views)
Permalink
// Add your reply above here
==================================================
Matthew Rolf updated this ticket at October 13th, 2010 @ 02:14 AM

1. I agree with David.

2. Yes.

-Matt
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.1
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #206] Keyword Autocomplete includes deleted keywords [ In reply to ]
no-reply at lighthouseapp
Oct 13, 2010, 1:26 AM
Post #4 of 6 (2220 views)
Permalink
// Add your reply above here
==================================================
Greg Heo updated this ticket at October 13th, 2010 @ 02:55 AM

In reviewing my patch I realize I'm not being consistent with permissions.

Reactivating a deleted keyword – CREATE or EDIT? I'm leaning towards CREATE since there's no RECALL for keywords.
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.1
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #206] Keyword Autocomplete includes deleted keywords [ In reply to ]
no-reply at lighthouseapp
Oct 13, 2010, 6:50 AM
Post #5 of 6 (2215 views)
Permalink
// Add your reply above here
==================================================
theory updated this ticket at October 13th, 2010 @ 01:49 PM

CREATE, as re-activating a keyword should be viewed as the same as creating a new one.

One downside though, I realize, is that if a keyword is re-activated, that means it will suddenly be associated with stories and categories it was associated with before. I'm leaning towards thinking that this is an undesirable behavior.

David
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.1
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #206] Keyword Autocomplete includes deleted keywords [ In reply to ]
no-reply at lighthouseapp
Oct 13, 2010, 9:09 AM
Post #6 of 6 (2220 views)
Permalink
// Add your reply above here
==================================================
Greg Heo updated this ticket at October 13th, 2010 @ 04:09 PM

Makes sense. I'll stick with the original "don't show deleted keywords" for now.
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.1
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/206-keyword-autocomplete-includes-deleted-keywords/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal